commit 06270c9eac5a68b1b8e17aebbd8384c1196c6fdc
author Shahbaz Youssefi <syoussefi@chromium.org> Wed Oct 03 17:00:25 2018 -0400
committer Commit Bot <commit-bot@chromium.org> Fri Oct 05 14:40:54 2018 +0000
tree d70307d9515bbf7fed4f72413ce313d5cdff14af
parent 5476e805a321d786f8b6a003ab95b1bee0c30964

Vulkan: Safer struct initialization

Using x = {}; before filling out each field, we can be sure any missing
field is 0 initialized.  This in turn helps us not have to specify
certain fields that are generally unused (at the moment), such
as pNext.

Bug: angleproject:2860
Change-Id: Ia1fa2db3ecfb316673a02ac0c5e13e47e055a19f
Reviewed-on: https://chromium-review.googlesource.com/c/1259764
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

src/libANGLE/renderer/vulkan/CommandGraph.cpp

diff --git a/src/libANGLE/renderer/vulkan/CommandGraph.cpp b/src/libANGLE/renderer/vulkan/CommandGraph.cpp
index ca59f87..84b3c31 100644
--- a/src/libANGLE/renderer/vulkan/CommandGraph.cpp
+++ b/src/libANGLE/renderer/vulkan/CommandGraph.cpp
@@ -30,18 +30,16 @@
 {
     ASSERT(!commandBuffer->valid());
 
-    VkCommandBufferAllocateInfo createInfo;
+    VkCommandBufferAllocateInfo createInfo = {};
     createInfo.sType              = VK_STRUCTURE_TYPE_COMMAND_BUFFER_ALLOCATE_INFO;
-    createInfo.pNext              = nullptr;
     createInfo.commandPool        = commandPool.getHandle();
     createInfo.level              = VK_COMMAND_BUFFER_LEVEL_SECONDARY;
     createInfo.commandBufferCount = 1;
 
     ANGLE_TRY(commandBuffer->init(context, createInfo));
 
-    VkCommandBufferBeginInfo beginInfo;
+    VkCommandBufferBeginInfo beginInfo = {};
     beginInfo.sType            = VK_STRUCTURE_TYPE_COMMAND_BUFFER_BEGIN_INFO;
-    beginInfo.pNext            = nullptr;
     beginInfo.flags            = flags | VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT;
     beginInfo.pInheritanceInfo = &inheritanceInfo;
 
@@ -235,9 +233,8 @@
 {
     ASSERT(!mHasChildren);
 
-    VkCommandBufferInheritanceInfo inheritanceInfo;
+    VkCommandBufferInheritanceInfo inheritanceInfo = {};
     inheritanceInfo.sType                = VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO;
-    inheritanceInfo.pNext                = nullptr;
     inheritanceInfo.renderPass           = VK_NULL_HANDLE;
     inheritanceInfo.subpass              = 0;
     inheritanceInfo.framebuffer          = VK_NULL_HANDLE;
@@ -263,9 +260,8 @@
     ANGLE_TRY(context->getRenderer()->getCompatibleRenderPass(context, mRenderPassDesc,
                                                               &compatibleRenderPass));
 
-    VkCommandBufferInheritanceInfo inheritanceInfo;
+    VkCommandBufferInheritanceInfo inheritanceInfo = {};
     inheritanceInfo.sType                = VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO;
-    inheritanceInfo.pNext                = nullptr;
     inheritanceInfo.renderPass           = compatibleRenderPass->getHandle();
     inheritanceInfo.subpass              = 0;
     inheritanceInfo.framebuffer          = mRenderPassFramebuffer.getHandle();
@@ -384,9 +380,8 @@
 
         ANGLE_TRY(mInsideRenderPassCommands.end(context));
 
-        VkRenderPassBeginInfo beginInfo;
+        VkRenderPassBeginInfo beginInfo    = {};
         beginInfo.sType                    = VK_STRUCTURE_TYPE_RENDER_PASS_BEGIN_INFO;
-        beginInfo.pNext                    = nullptr;
         beginInfo.renderPass               = renderPass->getHandle();
         beginInfo.framebuffer              = mRenderPassFramebuffer.getHandle();
         beginInfo.renderArea.offset.x      = static_cast<uint32_t>(mRenderPassRenderArea.x);
@@ -448,9 +443,8 @@
                                            CommandPool *commandPool,
                                            CommandBuffer *primaryCommandBufferOut)
 {
-    VkCommandBufferAllocateInfo primaryInfo;
+    VkCommandBufferAllocateInfo primaryInfo = {};
     primaryInfo.sType              = VK_STRUCTURE_TYPE_COMMAND_BUFFER_ALLOCATE_INFO;
-    primaryInfo.pNext              = nullptr;
     primaryInfo.commandPool        = commandPool->getHandle();
     primaryInfo.level              = VK_COMMAND_BUFFER_LEVEL_PRIMARY;
     primaryInfo.commandBufferCount = 1;
@@ -469,9 +463,8 @@
 
     std::vector<CommandGraphNode *> nodeStack;
 
-    VkCommandBufferBeginInfo beginInfo;
+    VkCommandBufferBeginInfo beginInfo = {};
     beginInfo.sType            = VK_STRUCTURE_TYPE_COMMAND_BUFFER_BEGIN_INFO;
-    beginInfo.pNext            = nullptr;
     beginInfo.flags            = 0;
     beginInfo.pInheritanceInfo = nullptr;