commit 06270c9eac5a68b1b8e17aebbd8384c1196c6fdc
author Shahbaz Youssefi <syoussefi@chromium.org> Wed Oct 03 17:00:25 2018 -0400
committer Commit Bot <commit-bot@chromium.org> Fri Oct 05 14:40:54 2018 +0000
tree d70307d9515bbf7fed4f72413ce313d5cdff14af
parent 5476e805a321d786f8b6a003ab95b1bee0c30964

Vulkan: Safer struct initialization

Using x = {}; before filling out each field, we can be sure any missing
field is 0 initialized.  This in turn helps us not have to specify
certain fields that are generally unused (at the moment), such
as pNext.

Bug: angleproject:2860
Change-Id: Ia1fa2db3ecfb316673a02ac0c5e13e47e055a19f
Reviewed-on: https://chromium-review.googlesource.com/c/1259764
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

src/libANGLE/renderer/vulkan/FramebufferVk.cpp

diff --git a/src/libANGLE/renderer/vulkan/FramebufferVk.cpp b/src/libANGLE/renderer/vulkan/FramebufferVk.cpp
index a43eae9..7569347 100644
--- a/src/libANGLE/renderer/vulkan/FramebufferVk.cpp
+++ b/src/libANGLE/renderer/vulkan/FramebufferVk.cpp
@@ -458,7 +458,7 @@
     ANGLE_TRY(
         readPixelsImpl(contextVk, copyArea, packPixelsParams, aspect, readRenderTarget, destPtr));
 
-    VkBufferImageCopy copyRegion;
+    VkBufferImageCopy copyRegion               = {};
     copyRegion.bufferOffset                    = destOffset;
     copyRegion.bufferImageHeight               = copyArea.height;
     copyRegion.bufferRowLength                 = copyArea.width;
@@ -854,10 +854,9 @@
 
     ASSERT(!attachments.empty());
 
-    VkFramebufferCreateInfo framebufferInfo;
+    VkFramebufferCreateInfo framebufferInfo = {};
 
     framebufferInfo.sType           = VK_STRUCTURE_TYPE_FRAMEBUFFER_CREATE_INFO;
-    framebufferInfo.pNext           = nullptr;
     framebufferInfo.flags           = 0;
     framebufferInfo.renderPass      = renderPass->getHandle();
     framebufferInfo.attachmentCount = static_cast<uint32_t>(attachments.size());
@@ -887,7 +886,7 @@
     ANGLE_TRY(getCommandBufferForDraw(contextVk, &commandBuffer, &mode));
 
     // The array layer is offset by the ImageView. So we shouldn't need to set a base array layer.
-    VkClearRect clearRect;
+    VkClearRect clearRect    = {};
     clearRect.baseArrayLayer = 0;
     clearRect.layerCount     = 1;
 
@@ -1175,7 +1174,7 @@
     ANGLE_TRY(mReadPixelBuffer.allocate(contextVk, allocationSize, &readPixelBuffer, &bufferHandle,
                                         &stagingOffset, &newBufferAllocated));
 
-    VkBufferImageCopy region;
+    VkBufferImageCopy region               = {};
     region.bufferImageHeight               = area.height;
     region.bufferOffset                    = stagingOffset;
     region.bufferRowLength                 = area.width;