commit 1056726094b11c834b6623d378baf3c7a19c00af
author Jamie Madill <jmadill@chromium.org> Thu Apr 17 16:40:00 2014 -0400
committer Jamie Madill <jmadill@chromium.org> Thu Apr 17 20:49:35 2014 +0000
tree 405b5b5831461c83fef8a02296f54b7fa3e93d0a
parent 4f26786863c81244acdd5b36738ae25e2c56b312

Fix build with Clang.

Clang's validation is a bit more thorough than GCC's or MSVC's and
picked up a few new errors and warnings. We missed a few default
cases in switches and used an improper type for default arguments.

BUG=angle:568

Change-Id: I34239c6c5c785ad1e62917fc37c3243f4c5b5f1b
Reviewed-on: https://chromium-review.googlesource.com/195472
Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

src/compiler/translator/OutputHLSL.cpp

diff --git a/src/compiler/translator/OutputHLSL.cpp b/src/compiler/translator/OutputHLSL.cpp
index 37812ff..e79474a 100644
--- a/src/compiler/translator/OutputHLSL.cpp
+++ b/src/compiler/translator/OutputHLSL.cpp
@@ -4192,6 +4192,8 @@
       case EvqCentroidOut:
       case EvqVertexOut:
         return true;
+
+      default: break;
     }
 
     return false;
@@ -4208,6 +4210,8 @@
       case EvqCentroidIn:
       case EvqFragmentIn:
         return true;
+
+      default: break;
     }
 
     return false;

src/compiler/translator/ParseContext.cpp

diff --git a/src/compiler/translator/ParseContext.cpp b/src/compiler/translator/ParseContext.cpp
index 75c4938..8ff9d30 100644
--- a/src/compiler/translator/ParseContext.cpp
+++ b/src/compiler/translator/ParseContext.cpp
@@ -638,6 +638,8 @@
             error(line, "cannot be used with a structure", getQualifierString(pType.qualifier));
             return true;
         }
+
+      default: break;
     }
 
     if (pType.qualifier != EvqUniform && samplerErrorCheck(line, pType, "samplers must be uniform"))

src/compiler/translator/SymbolTable.h

diff --git a/src/compiler/translator/SymbolTable.h b/src/compiler/translator/SymbolTable.h
index cbf6fa3..e661c5d 100644
--- a/src/compiler/translator/SymbolTable.h
+++ b/src/compiler/translator/SymbolTable.h
@@ -360,7 +360,7 @@
         insert(level, *function);
     }
 
-    TSymbol *find(const TString &name, int shaderVersion, bool *builtIn = false, bool *sameScope = false);
+    TSymbol *find(const TString &name, int shaderVersion, bool *builtIn = NULL, bool *sameScope = NULL);
     TSymbol *findBuiltIn(const TString &name, int shaderVersion);
     
     TSymbolTableLevel *getOuterLevel() {