commit 111a99e82dd7ae15e5dd75596844d90d63d74d26
author Geoff Lang <geofflang@chromium.org> Tue Oct 17 10:58:41 2017 -0400
committer Commit Bot <commit-bot@chromium.org> Fri Oct 20 05:18:17 2017 +0000
tree 1dc38c854d301888505c6632f3f303b18cb1046e
parent 02032bda51852a851501cbf7a2380ae67f2f7b05

Check that the requested extension is supported by the backend.

Previously, we would only check that the extension was requestable and
not verify that the driver could support it.

BUG=angleproject:1523

Change-Id: I5273920fc08a20beda54d4afaeb406c6c1c2056f
Reviewed-on: https://chromium-review.googlesource.com/723559
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

src/libANGLE/validationES2.cpp

diff --git a/src/libANGLE/validationES2.cpp b/src/libANGLE/validationES2.cpp
index d073c69..baec2cc 100644
--- a/src/libANGLE/validationES2.cpp
+++ b/src/libANGLE/validationES2.cpp
@@ -4224,7 +4224,7 @@
     return true;
 }
 
-bool ValidateRequestExtensionANGLE(ValidationContext *context, const GLchar *name)
+bool ValidateRequestExtensionANGLE(Context *context, const GLchar *name)
 {
     if (!context->getExtensions().requestExtension)
     {
@@ -4232,9 +4232,7 @@
         return false;
     }
 
-    const ExtensionInfoMap &extensionInfos = GetExtensionInfoMap();
-    auto extension                         = extensionInfos.find(name);
-    if (extension == extensionInfos.end() || !extension->second.Requestable)
+    if (!context->isExtensionRequestable(name))
     {
         context->handleError(InvalidOperation() << "Extension " << name << " is not requestable.");
         return false;