commit 14aa40f0213a9dbff02ab7200f058ad6bfa6f231
author Jamie Madill <jmadill@chromium.org> Wed Jan 07 15:12:47 2015 -0500
committer Jamie Madill <jmadill@chromium.org> Wed Jan 07 21:25:35 2015 +0000
tree be295e80890a5c7900788b8a1c38b8169af49b91
parent 054369e3c6c07e36e0ec4828a7f2efb93af5a2d1

Print ERR() errors to the debug output on Windows.

We can switch this on for Debug only. This will help developers
catch bugs more easily, and will only show up for internal
errors and major performance caveats. Currently it's far too easy
to miss these messages - it requires manually modifying debug.h,
looking at a text file and potentially also running Chromium with
an special flag.

BUG=angle:663

Change-Id: I75b3bd05fbc75d21607b9957134db8e8990c77b1
Reviewed-on: https://chromium-review.googlesource.com/239191
Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

src/common/debug.h

diff --git a/src/common/debug.h b/src/common/debug.h
index c177f51..d632725 100644
--- a/src/common/debug.h
+++ b/src/common/debug.h
@@ -20,8 +20,16 @@
 
 namespace gl
 {
+    enum MessageType
+    {
+        MESSAGE_TRACE,
+        MESSAGE_FIXME,
+        MESSAGE_ERR,
+        MESSAGE_EVENT,
+    };
+
     // Outputs text to the debugging log, or the debugging window
-    void trace(bool traceInDebugOnly, const char *format, ...);
+    void trace(bool traceInDebugOnly, MessageType messageType, const char *format, ...);
 
     // Returns whether D3DPERF is active.
     bool perfActive();
@@ -43,21 +51,21 @@
 
 // A macro to output a trace of a function call and its arguments to the debugging log
 #if defined(ANGLE_ENABLE_DEBUG_TRACE) || defined(ANGLE_ENABLE_DEBUG_ANNOTATIONS)
-#define TRACE(message, ...) gl::trace(true, "trace: %s(%d): " message "\n", __FUNCTION__, __LINE__, ##__VA_ARGS__)
+#define TRACE(message, ...) gl::trace(true, gl::MESSAGE_TRACE, "trace: %s(%d): " message "\n", __FUNCTION__, __LINE__, ##__VA_ARGS__)
 #else
 #define TRACE(message, ...) (void(0))
 #endif
 
 // A macro to output a function call and its arguments to the debugging log, to denote an item in need of fixing.
 #if defined(ANGLE_ENABLE_DEBUG_TRACE) || defined(ANGLE_ENABLE_DEBUG_ANNOTATIONS)
-#define FIXME(message, ...) gl::trace(false, "fixme: %s(%d): " message "\n", __FUNCTION__, __LINE__, ##__VA_ARGS__)
+#define FIXME(message, ...) gl::trace(false, gl::MESSAGE_FIXME, "fixme: %s(%d): " message "\n", __FUNCTION__, __LINE__, ##__VA_ARGS__)
 #else
 #define FIXME(message, ...) (void(0))
 #endif
 
 // A macro to output a function call and its arguments to the debugging log, in case of error.
 #if defined(ANGLE_ENABLE_DEBUG_TRACE) || defined(ANGLE_ENABLE_DEBUG_ANNOTATIONS)
-#define ERR(message, ...) gl::trace(false, "err: %s(%d): " message "\n", __FUNCTION__, __LINE__, ##__VA_ARGS__)
+#define ERR(message, ...) gl::trace(false, gl::MESSAGE_ERR, "err: %s(%d): " message "\n", __FUNCTION__, __LINE__, ##__VA_ARGS__)
 #else
 #define ERR(message, ...) (void(0))
 #endif