commit 1ffad843be53a4d1707b3cd7e948f50e8927c0c3
author Frank Henigman <fjhenigman@chromium.org> Mon Sep 24 23:40:45 2018 -0400
committer Commit Bot <commit-bot@chromium.org> Mon Oct 01 20:16:57 2018 +0000
tree f5656a7d975b58288f98d30f4354ca4b68ec4547
parent 1dfd8ae2e0e6e8044603529642157f1ff9c4ddcc

Remove PixelPackState from PackPixelsParams.

Only one flag ("reverseRowOrder") from PixelPackState was being used,
so instead of including the entire struct in PackPixelsParams, just
include the one flag.

BUG=angleproject:2718

Change-Id: I32e8b30383d198ecba9bf1719c32dda0938fc969
Reviewed-on: https://chromium-review.googlesource.com/1242210
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@google.com>

src/libANGLE/renderer/renderer_utils.cpp

diff --git a/src/libANGLE/renderer/renderer_utils.cpp b/src/libANGLE/renderer/renderer_utils.cpp
index b677333..280b3d9 100644
--- a/src/libANGLE/renderer/renderer_utils.cpp
+++ b/src/libANGLE/renderer/renderer_utils.cpp
@@ -169,18 +169,16 @@
 PackPixelsParams::PackPixelsParams(const gl::Rectangle &areaIn,
                                    const angle::Format &destFormat,
                                    GLuint outputPitchIn,
-                                   const gl::PixelPackState &packIn,
+                                   bool reverseRowOrderIn,
                                    gl::Buffer *packBufferIn,
                                    ptrdiff_t offsetIn)
     : area(areaIn),
       destFormat(&destFormat),
       outputPitch(outputPitchIn),
       packBuffer(packBufferIn),
-      pack(),
+      reverseRowOrder(reverseRowOrderIn),
       offset(offsetIn)
 {
-    pack.alignment       = packIn.alignment;
-    pack.reverseRowOrder = packIn.reverseRowOrder;
 }
 
 void PackPixels(const PackPixelsParams &params,
@@ -194,7 +192,7 @@
     const uint8_t *source = sourceIn;
     int inputPitch        = inputPitchIn;
 
-    if (params.pack.reverseRowOrder)
+    if (params.reverseRowOrder)
     {
         source += inputPitch * (params.area.height - 1);
         inputPitch = -inputPitch;