commit 2c43325dd4f0f570649dacd3704bbac6e9b70ae5
author Jamie Madill <jmadill@chromium.org> Wed Dec 03 12:36:54 2014 -0500
committer Jamie Madill <jmadill@chromium.org> Thu Dec 04 21:57:47 2014 +0000
tree d21f114253898215f74b4776c817386a38460c10
parent 68439854bdfc3843f52f12de589af92862426849

Fix double delete with invariant varyings.

The compiler would leave some TString variables lying around
after the pool gets released, leading to a potential crash.

BUG=angle:846

Change-Id: I484ed9b14bba9bf653f6ed4001ae79f87791b0dd
Reviewed-on: https://chromium-review.googlesource.com/232780
Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

src/compiler/translator/ParseContext.cpp

diff --git a/src/compiler/translator/ParseContext.cpp b/src/compiler/translator/ParseContext.cpp
index 89ab9a5..148179c 100644
--- a/src/compiler/translator/ParseContext.cpp
+++ b/src/compiler/translator/ParseContext.cpp
@@ -1390,7 +1390,7 @@
             recover();
             return NULL;
         }
-        symbolTable.addInvariantVarying(*identifier);
+        symbolTable.addInvariantVarying(std::string(identifier->c_str()));
         const TVariable *variable = getNamedVariable(identifierLoc, identifier, symbol);
         ASSERT(variable);
         const TType &type = variable->getType();