commit 2fc0806f559502882f9d28f2e64445873e0ee884
author Jamie Madill <jmadill@chromium.org> Thu May 10 15:10:55 2018 -0400
committer Commit Bot <commit-bot@chromium.org> Thu May 10 23:33:04 2018 +0000
tree f1485d2b3a9e36bc76fe448c0e7051fe039caa9b
parent 618598179a5d5331a93201c015fc3e2304681e39

Micro-optimize uniform updates.

This CL is adapted from work by matavenrath@nvidia.com. It does the
following small optimizations:

* inlines a bunch of accessors.
* reorders checks to hit the cache more often

Also some small style updates.

Bug: angleproject:1671
Change-Id: I8f21318e6644dcfe1f99c98f7f377742fcad78d3
Reviewed-on: https://chromium-review.googlesource.com/1054367
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

src/libANGLE/validationES.cpp

diff --git a/src/libANGLE/validationES.cpp b/src/libANGLE/validationES.cpp
index 56d6e76..cbf4ef2 100644
--- a/src/libANGLE/validationES.cpp
+++ b/src/libANGLE/validationES.cpp
@@ -2096,7 +2096,7 @@
     const auto &uniform = program->getUniformByIndex(uniformLocation.index);
 
     // attempting to write an array to a non-array uniform is an INVALID_OPERATION
-    if (!uniform.isArray() && count > 1)
+    if (count > 1 && !uniform.isArray())
     {
         context->handleError(InvalidOperation());
         return false;