Clean up Program::validate.
This method should really be an Impl method, since it corresponds to
a specific OpenGL call. Making it an Impl method also allows us to
remove applyUniforms, which doesn't correspond to a GL call.
BUG=angleproject:1123
Change-Id: I2abee3cfaa7393cad44566782d51ed701e84846b
Reviewed-on: https://chromium-review.googlesource.com/293825
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>
diff --git a/src/libANGLE/renderer/gl/ProgramGL.cpp b/src/libANGLE/renderer/gl/ProgramGL.cpp
index 665c390..56fed09 100644
--- a/src/libANGLE/renderer/gl/ProgramGL.cpp
+++ b/src/libANGLE/renderer/gl/ProgramGL.cpp
@@ -203,6 +203,12 @@
return LinkResult(true, gl::Error(GL_NO_ERROR));
}
+GLboolean ProgramGL::validate(const gl::Caps & /*caps*/, gl::InfoLog * /*infoLog*/)
+{
+ // TODO(jmadill): implement validate
+ return true;
+}
+
void ProgramGL::bindAttributeLocation(GLuint index, const std::string &name)
{
mFunctions->bindAttribLocation(mProgramID, index, name.c_str());
@@ -365,13 +371,6 @@
return true;
}
-gl::Error ProgramGL::applyUniforms()
-{
- //UNIMPLEMENTED();
- // TODO(geofflang)
- return gl::Error(GL_NO_ERROR);
-}
-
void ProgramGL::reset()
{
ProgramImpl::reset();