commit 3755c48d1ab7831ff122144afb8372fca5c406f8
author Olli Etuaho <oetuaho@nvidia.com> Fri Oct 13 15:40:26 2017 +0300
committer Commit Bot <commit-bot@chromium.org> Fri Oct 13 13:28:24 2017 +0000
tree 17724b5d341243f937192997df1a013f1184fa62
parent 42975644246d68d1d3dc5cfa476adff09d0c8cb8

Fix multiview transform feedback test

The multiview transform feedback test was not compliant with the GLES
spec for transform feedback. The issue had to do with this part of
section 2.15.2 of GLES 3.0.5 spec:

"The error INVALID_OPERATION is also generated by
BeginTransformFeedback if no binding points would be used, either
because no program object is active or because the active program
object has specified no output variables to record."

Fix this.

BUG=angleproject:2184
TEST=angle_end2end_tests on NVIDIA 387.92 drivers

Change-Id: I24816d2c24df0072179f21ead892bd2c9ba696d2
Reviewed-on: https://chromium-review.googlesource.com/718702
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

src/tests/gl_tests/MultiviewDrawTest.cpp

diff --git a/src/tests/gl_tests/MultiviewDrawTest.cpp b/src/tests/gl_tests/MultiviewDrawTest.cpp
index e55f9d1..91e2c92 100644
--- a/src/tests/gl_tests/MultiviewDrawTest.cpp
+++ b/src/tests/gl_tests/MultiviewDrawTest.cpp
@@ -706,15 +706,21 @@
     const GLint viewportOffsets[4] = {0, 0, 2, 0};
 
     const std::string &vsSource =
-        "#version 300 es\n"
-        "void main()\n"
-        "{}\n";
+        R"(#version 300 es
+        out float tfVarying;
+        void main()
+        {
+            tfVarying = 1.0;
+        })";
     const std::string &fsSource =
-        "#version 300 es\n"
-        "precision mediump float;\n"
-        "void main()\n"
-        "{}\n";
-    ANGLE_GL_PROGRAM(program, vsSource, fsSource);
+        R"(#version 300 es
+        precision mediump float;
+        void main()
+        {})";
+    std::vector<std::string> tfVaryings;
+    tfVaryings.push_back(std::string("tfVarying"));
+    ANGLE_GL_PROGRAM_TRANSFORM_FEEDBACK(program, vsSource, fsSource, tfVaryings,
+                                        GL_SEPARATE_ATTRIBS);
     glUseProgram(program);
 
     GLBuffer tbo;
@@ -723,6 +729,9 @@
 
     GLTransformFeedback transformFeedback;
     glBindTransformFeedback(GL_TRANSFORM_FEEDBACK, transformFeedback);
+
+    glBindBufferBase(GL_TRANSFORM_FEEDBACK_BUFFER, 0, tbo);
+
     glBeginTransformFeedback(GL_TRIANGLES);
     ASSERT_GL_NO_ERROR();