commit 37b697edf8fe6a850e71dadcd217f8ef29feb86c
author Olli Etuaho <oetuaho@nvidia.com> Mon Jan 29 12:19:27 2018 +0200
committer Commit Bot <commit-bot@chromium.org> Mon Jan 29 21:08:32 2018 +0000
tree 556702416cd943896aa4824bdf48a13e97d8bd6b
parent e4741fd0f2bce711a90bdebe2ac8e83cf944b8e8

Only return symbol from TSymbolTable::find

Whether the symbol is built-in can be easily determined from the
SymbolType stored in the symbol, it doesn't need to be returned
separately. The sameScope value that could be returned from
TSymbolTable::find was never used, so that can be removed as well.

BUG=angleproject:2267
TEST=angle_unittests

Change-Id: I06958741ebec67d496f830a83b4f6f1359632f45
Reviewed-on: https://chromium-review.googlesource.com/891021
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

src/compiler/translator/SymbolTable.cpp

diff --git a/src/compiler/translator/SymbolTable.cpp b/src/compiler/translator/SymbolTable.cpp
index 7548880..4bc29a4 100644
--- a/src/compiler/translator/SymbolTable.cpp
+++ b/src/compiler/translator/SymbolTable.cpp
@@ -139,10 +139,7 @@
     return firstDeclaration;
 }
 
-const TSymbol *TSymbolTable::find(const TString &name,
-                                  int shaderVersion,
-                                  bool *builtIn,
-                                  bool *sameScope) const
+const TSymbol *TSymbolTable::find(const TString &name, int shaderVersion) const
 {
     int level       = currentLevel();
     TSymbol *symbol = nullptr;
@@ -158,12 +155,8 @@
             level--;
 
         symbol = table[level]->find(name);
-    } while (symbol == nullptr && --level >= 0);
-
-    if (builtIn)
-        *builtIn = (level <= LAST_BUILTIN_LEVEL);
-    if (sameScope)
-        *sameScope = (level == currentLevel());
+        level--;
+    } while (symbol == nullptr && level >= 0);
 
     return symbol;
 }