commit 3d86e89bce7abacff20285c0d6e8525d9ef0ce60
author Shahbaz Youssefi <syoussefi@chromium.org> Fri Nov 02 16:29:44 2018 -0400
committer Commit Bot <commit-bot@chromium.org> Mon Nov 05 18:12:32 2018 +0000
tree b1e202b1746c28f9532d43d7dcb40b066b2fb1dd
parent 37297a4f14406f49031b6855d2d8fa7ad881fd1b

Vulkan: properly handle 0-width or 0-height framebuffers

The test for whether 0-width or 0-height is not given was doing

    width != 0 || height != 0

which mistakenly used || instead of &&.

Bug: angleproject:2910
Change-Id: Iaa41edffcfe1f8553e8fbefb9bc3b12a7f33a5a6
Reviewed-on: https://chromium-review.googlesource.com/c/1316028
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

src/libANGLE/renderer/vulkan/RenderbufferVk.cpp

diff --git a/src/libANGLE/renderer/vulkan/RenderbufferVk.cpp b/src/libANGLE/renderer/vulkan/RenderbufferVk.cpp
index 1411da3..319bd66 100644
--- a/src/libANGLE/renderer/vulkan/RenderbufferVk.cpp
+++ b/src/libANGLE/renderer/vulkan/RenderbufferVk.cpp
@@ -62,7 +62,7 @@
         }
     }
 
-    if (!mImage.valid() && (width != 0 || height != 0))
+    if (!mImage.valid() && (width != 0 && height != 0))
     {
         const angle::Format &textureFormat = vkFormat.textureFormat();
         bool isDepthOrStencilFormat = textureFormat.depthBits > 0 || textureFormat.stencilBits > 0;