commit 3e313805e5a2e2eeda5822b3562e40e1bcc5ef83
author Luc Ferron <lucferron@chromium.org> Mon Jun 11 14:44:33 2018 -0400
committer Commit Bot <commit-bot@chromium.org> Tue Jun 12 22:09:23 2018 +0000
tree 55f05d4dc287d2680976bfa51073b768cc49cdb7
parent 9c0e3063ddb190700c8f27360400339b7645d39c

Vulkan: Line loop edge case with ubyte indices

Bug: angleproject:2637
Change-Id: I2cec129ed1aa0e55e0dbf1d353caa65a51c528a3
Reviewed-on: https://chromium-review.googlesource.com/1096017
Commit-Queue: Luc Ferron <lucferron@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

src/libANGLE/renderer/vulkan/VertexArrayVk.cpp

diff --git a/src/libANGLE/renderer/vulkan/VertexArrayVk.cpp b/src/libANGLE/renderer/vulkan/VertexArrayVk.cpp
index ce991d0..4a72c89 100644
--- a/src/libANGLE/renderer/vulkan/VertexArrayVk.cpp
+++ b/src/libANGLE/renderer/vulkan/VertexArrayVk.cpp
@@ -417,8 +417,8 @@
         if (!elementArrayBuffer)
         {
             ANGLE_TRY(mLineLoopHelper.getIndexBufferForClientElementArray(
-                renderer, drawCallParams.indices(), indexType, drawCallParams.indexCount(),
-                &mCurrentElementArrayBufferHandle, &mCurrentElementArrayBufferOffset));
+                renderer, drawCallParams, &mCurrentElementArrayBufferHandle,
+                &mCurrentElementArrayBufferOffset));
         }
         else
         {
@@ -505,9 +505,10 @@
     }
     else if (mIndexBufferDirty || newCommandBuffer)
     {
-        if (drawCallParams.type() == GL_UNSIGNED_BYTE)
+        if (drawCallParams.type() == GL_UNSIGNED_BYTE &&
+            drawCallParams.mode() != gl::PrimitiveMode::LineLoop)
         {
-            // TODO(fjhenigman): Index format translation.
+            // TODO(fjhenigman): Index format translation for non line-loop calls.
             UNIMPLEMENTED();
             return gl::InternalError()
                    << "Unsigned byte translation is not implemented for indices in a buffer object";