commit 3fd614d06e50fb98d1434fabf31e8583516ad5c1
author jchen10 <jie.a.chen@intel.com> Mon Aug 13 12:21:58 2018 +0800
committer Commit Bot <commit-bot@chromium.org> Thu Aug 16 02:29:46 2018 +0000
tree 25db670cf5cba2f46c301459d3c12321194a3e77
parent 156da4c911bab669fca25f95790791ab11746c57

Refactor Context dependency for resolveCompile

The context parameter of Shader::resolveCompile method causes a bad
impact that many methods in Shader, Program etc. have to have a same
context parameter. By removing it, these methods can be decoupled
from Context.

BUG=chromium:849576

Change-Id: Ia5545ee9dce45794550f6086bc0e6c4707e1276e
Reviewed-on: https://chromium-review.googlesource.com/1172202
Commit-Queue: Jie A Chen <jie.a.chen@intel.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

src/libANGLE/renderer/null/ShaderNULL.cpp

diff --git a/src/libANGLE/renderer/null/ShaderNULL.cpp b/src/libANGLE/renderer/null/ShaderNULL.cpp
index 59ae007..4e3b9e7 100644
--- a/src/libANGLE/renderer/null/ShaderNULL.cpp
+++ b/src/libANGLE/renderer/null/ShaderNULL.cpp
@@ -30,14 +30,12 @@
     return 0;
 }
 
-bool ShaderNULL::postTranslateCompile(const gl::Context *context,
-                                      gl::Compiler *compiler,
-                                      std::string *infoLog)
+bool ShaderNULL::postTranslateCompile(gl::Compiler *compiler, std::string *infoLog)
 {
     return true;
 }
 
-std::string ShaderNULL::getDebugInfo(const gl::Context *context) const
+std::string ShaderNULL::getDebugInfo() const
 {
     return "";
 }

src/libANGLE/renderer/null/ShaderNULL.h

diff --git a/src/libANGLE/renderer/null/ShaderNULL.h b/src/libANGLE/renderer/null/ShaderNULL.h
index 0a415f3..04a58c0 100644
--- a/src/libANGLE/renderer/null/ShaderNULL.h
+++ b/src/libANGLE/renderer/null/ShaderNULL.h
@@ -26,11 +26,9 @@
                                                    std::stringstream *sourceStream,
                                                    std::string *sourcePath) override;
     // Returns success for compiling on the driver. Returns success.
-    bool postTranslateCompile(const gl::Context *context,
-                              gl::Compiler *compiler,
-                              std::string *infoLog) override;
+    bool postTranslateCompile(gl::Compiler *compiler, std::string *infoLog) override;
 
-    std::string getDebugInfo(const gl::Context *context) const override;
+    std::string getDebugInfo() const override;
 };
 
 }  // namespace rx