commit 44efa0b8cc9743952b57486b2b4b75c9dd585702
author Arun Patole <apatole@nvidia.com> Wed Mar 04 17:11:05 2015 +0530
committer Jamie Madill <jmadill@chromium.org> Wed Mar 11 15:21:09 2015 +0000
tree 0c11d8ced055ff01fbee5e479452431b358a572d
parent 56d1003ef9609c79d7f48c7dd7afd09c6c268a3b

Conditionally enable IEEE strictness for isnan()

ANGLE's ESSL3 built-in function isnan() implementation just uses HLSL
intrinsic function isnan(). For HLSL intrinsic function isnan() to work
properly, IEEE strictness needs to be enabled for D3D compiler.

This change detects use of isnan() in shaders and passes compiler flag
D3DCOMPILE_IEEE_STRICTNESS whenever isnan is used in shaders. This
change also moves existing workarounds in D3DWorkaroundType to
D3DCompilerWorkarounds.

BUG=angle:927
TEST= dEQP tests
dEQP-GLES3.functional.shaders.builtin_functions.common.isnan.*

Change-Id: I1ce5b1a7a825fdd720a37dc9aeb71320e55162d9
Reviewed-on: https://chromium-review.googlesource.com/255834
Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Tested-by: Jamie Madill <jmadill@chromium.org>

src/compiler/translator/OutputHLSL.cpp

diff --git a/src/compiler/translator/OutputHLSL.cpp b/src/compiler/translator/OutputHLSL.cpp
index bebaeb5..f3aa556 100644
--- a/src/compiler/translator/OutputHLSL.cpp
+++ b/src/compiler/translator/OutputHLSL.cpp
@@ -126,6 +126,7 @@
     mUsesXor = false;
     mUsesDiscardRewriting = false;
     mUsesNestedBreak = false;
+    mRequiresIEEEStrictCompiling = false;
 
     mUniqueIndex = 0;
 
@@ -353,6 +354,11 @@
         out << "#define ANGLE_USES_NESTED_BREAK\n";
     }
 
+    if (mRequiresIEEEStrictCompiling)
+    {
+        out << "#define ANGLE_REQUIRES_IEEE_STRICT_COMPILING\n";
+    }
+
     out << "#ifdef ANGLE_ENABLE_LOOP_FLATTEN\n"
            "#define LOOP [loop]\n"
            "#define FLATTEN [flatten]\n"
@@ -1690,7 +1696,10 @@
         break;
       case EOpCeil:             outputTriplet(visit, "ceil(", "", ")");      break;
       case EOpFract:            outputTriplet(visit, "frac(", "", ")");      break;
-      case EOpIsNan:            outputTriplet(visit, "isnan(", "", ")");     break;
+      case EOpIsNan:
+        outputTriplet(visit, "isnan(", "", ")");
+        mRequiresIEEEStrictCompiling = true;
+        break;
       case EOpIsInf:            outputTriplet(visit, "isinf(", "", ")");     break;
       case EOpFloatBitsToInt:   outputTriplet(visit, "asint(", "", ")");     break;
       case EOpFloatBitsToUint:  outputTriplet(visit, "asuint(", "", ")");    break;