commit 51af38b869f276677b7125bf3e352cf096a7dff2
author Jamie Madill <jmadill@chromium.org> Sun Apr 15 08:50:56 2018 -0400
committer Commit Bot <commit-bot@chromium.org> Mon Apr 16 19:09:51 2018 +0000
tree 1f6ff1bcfb35ba57cd533ce07bd2078a082c8484
parent a7be1f7720ba4914bdb945a1964dfe983304d4f0

Optimize ValidateDrawAttribs: Part 1.

This moves several loop checks outside the loop, and uses more of the
gl::AttributesMask class to do bitset operations instead of using
checks and for loops.

Bug: angleproject:1391
Change-Id: I90a1a7db550390ecd1402cf5a8a6677fd852b7b0
Reviewed-on: https://chromium-review.googlesource.com/1008273
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

src/libANGLE/VertexArray.cpp

diff --git a/src/libANGLE/VertexArray.cpp b/src/libANGLE/VertexArray.cpp
index 06362d0..37ad8b7 100644
--- a/src/libANGLE/VertexArray.cpp
+++ b/src/libANGLE/VertexArray.cpp
@@ -36,6 +36,11 @@
     return (mClientMemoryAttribsMask & mEnabledAttributesMask);
 }
 
+bool VertexArrayState::hasEnabledNullPointerClientArray() const
+{
+    return (mNullPointerClientMemoryAttribsMask & mEnabledAttributesMask).any();
+}
+
 // VertexArray implementation.
 VertexArray::VertexArray(rx::GLImplFactory *factory,
                          GLuint id,
@@ -272,6 +277,8 @@
     setDirtyAttribBit(attribIndex, DIRTY_ATTRIB_POINTER);
 
     mState.mClientMemoryAttribsMask.set(attribIndex, boundBuffer == nullptr);
+    mState.mNullPointerClientMemoryAttribsMask.set(attribIndex,
+                                                   boundBuffer == nullptr && pointer == nullptr);
 }
 
 void VertexArray::setElementArrayBuffer(const Context *context, Buffer *buffer)