commit 526392dd96e59da3e59f7b547356e3c39da5be17
author Jamie Madill <jmadill@chromium.org> Fri Nov 16 09:35:14 2018 -0500
committer Commit Bot <commit-bot@chromium.org> Fri Nov 16 15:47:52 2018 +0000
tree ed43ae42b1aeb08384012114949aa459745180e9
parent 417ac91cdb062fcadbeeeae2c0e1ba9bad426c3d

Use angle::Result in front-end (Part 9)

This removes the ANGLE_TRY_HANDLE macro. Also the internal uses of
gl::ErrorStreamBase. There are remaining uses in the validation code.

Further progress will be blocked on removing egl::Error and the use
of gl::Error in the validation layer.

Also reduces binary size by up to 4k.

Bug: angleproject:2491
Change-Id: I3e0481f99738f9f24256c10e73f3efcce9826a35
Reviewed-on: https://chromium-review.googlesource.com/c/1334427
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

src/libANGLE/ResourceManager.cpp

diff --git a/src/libANGLE/ResourceManager.cpp b/src/libANGLE/ResourceManager.cpp
index b00d379..7b8294a 100644
--- a/src/libANGLE/ResourceManager.cpp
+++ b/src/libANGLE/ResourceManager.cpp
@@ -10,6 +10,7 @@
 #include "libANGLE/ResourceManager.h"
 
 #include "libANGLE/Buffer.h"
+#include "libANGLE/Context.h"
 #include "libANGLE/Fence.h"
 #include "libANGLE/Path.h"
 #include "libANGLE/Program.h"
@@ -18,7 +19,7 @@
 #include "libANGLE/Sampler.h"
 #include "libANGLE/Shader.h"
 #include "libANGLE/Texture.h"
-#include "libANGLE/renderer/GLImplFactory.h"
+#include "libANGLE/renderer/ContextImpl.h"
 
 namespace gl
 {
@@ -336,24 +337,28 @@
 
 // PathManager Implementation.
 
-PathManager::PathManager()
-{
-}
+PathManager::PathManager() = default;
 
-Error PathManager::createPaths(rx::GLImplFactory *factory, GLsizei range, GLuint *createdOut)
+angle::Result PathManager::createPaths(Context *context, GLsizei range, GLuint *createdOut)
 {
     *createdOut = 0;
 
     // Allocate client side handles.
     const GLuint client = mHandleAllocator.allocateRange(static_cast<GLuint>(range));
     if (client == HandleRangeAllocator::kInvalidHandle)
-        return OutOfMemory() << "Failed to allocate path handle range.";
+    {
+        context->handleError(GL_OUT_OF_MEMORY, "Failed to allocate path handle range.", __FILE__,
+                             ANGLE_FUNCTION, __LINE__);
+        return angle::Result::Stop();
+    }
 
-    const auto &paths = factory->createPaths(range);
+    const auto &paths = context->getImplementation()->createPaths(range);
     if (paths.empty())
     {
         mHandleAllocator.releaseRange(client, range);
-        return OutOfMemory() << "Failed to allocate path objects.";
+        context->handleError(GL_OUT_OF_MEMORY, "Failed to allocate path objects.", __FILE__,
+                             ANGLE_FUNCTION, __LINE__);
+        return angle::Result::Stop();
     }
 
     for (GLsizei i = 0; i < range; ++i)
@@ -363,7 +368,7 @@
         mPaths.assign(id, new Path(impl));
     }
     *createdOut = client;
-    return NoError();
+    return angle::Result::Continue();
 }
 
 void PathManager::deletePaths(GLuint first, GLsizei range)