commit 5f5320a965a4decbea1cdb87a85ceaf66053ec2f
author Geoff Lang <geofflang@chromium.org> Mon May 26 13:56:11 2014 -0400
committer Geoff Lang <geofflang@chromium.org> Tue May 27 20:20:05 2014 +0000
tree 805a5dda00109638f615a7e728947c56b35570d1
parent afc102609db7f5fcf317815b423147dfeb469a27

Use 'inout' qualifiers in generated HLSL for 'out' parameters.

With our added padding to some structures, using only 'out' in the
generated HLSL can cause warnings because not all of the structure members
are initialized.

BUG=angle:286

Change-Id: I866960883de487f19883fb2bc086c02703ea6271
Reviewed-on: https://chromium-review.googlesource.com/201364
Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

src/compiler/translator/OutputHLSL.cpp

diff --git a/src/compiler/translator/OutputHLSL.cpp b/src/compiler/translator/OutputHLSL.cpp
index 17223f1..d747ddd 100644
--- a/src/compiler/translator/OutputHLSL.cpp
+++ b/src/compiler/translator/OutputHLSL.cpp
@@ -3303,7 +3303,7 @@
     switch(qualifier)
     {
       case EvqIn:            return "in";
-      case EvqOut:           return "out";
+      case EvqOut:           return "inout"; // 'out' results in an HLSL error if not all fields are written, for GLSL it's undefined
       case EvqInOut:         return "inout";
       case EvqConstReadOnly: return "const";
       default: UNREACHABLE();