commit 61e16b449e4104f9218b42e0cba40190162aedeb
author Jamie Madill <jmadill@chromium.org> Mon Jun 19 11:13:23 2017 -0400
committer Jamie Madill <jmadill@chromium.org> Mon Jun 19 17:57:38 2017 +0000
tree 32e3d7718cc55a27da1cceaef001c344714740ac
parent 12b0b399aaa22d0f5df0784997753f74ecdb8e36

Context: Bind current display/surface.

Looking at the EGL spec, it says for eglGetCurrentDisplay:

"The display for the current context in the calling thread, for the
current rendering API, is returned."

This implies that MakeCurrent binds a display to a Context. There's
also pretty clear language for the read/draw Surface as well, that
they can only be bound to one Context/thread at a time. Hence we
don't need to duplicate this storage in the egl::Thread structure,
merely storing a pointer to the current Context, which has access
to the read/draw Surface and current Display.

BUG=angleproject:1156

Change-Id: Ia3b99d50b3591012c43e851834c1af02ff62a33f
Reviewed-on: https://chromium-review.googlesource.com/538865
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

src/libANGLE/validationES.cpp

diff --git a/src/libANGLE/validationES.cpp b/src/libANGLE/validationES.cpp
index bfdbc07..2fdb17e 100644
--- a/src/libANGLE/validationES.cpp
+++ b/src/libANGLE/validationES.cpp
@@ -3361,7 +3361,6 @@
 }
 
 bool ValidateEGLImageTargetTexture2DOES(Context *context,
-                                        egl::Display *display,
                                         GLenum target,
                                         egl::Image *image)
 {
@@ -3394,7 +3393,8 @@
             return false;
     }
 
-    if (!display->isValidImage(image))
+    ASSERT(context->getCurrentDisplay());
+    if (!context->getCurrentDisplay()->isValidImage(image))
     {
         context->handleError(InvalidValue() << "EGL image is not valid.");
         return false;
@@ -3420,7 +3420,6 @@
 }
 
 bool ValidateEGLImageTargetRenderbufferStorageOES(Context *context,
-                                                  egl::Display *display,
                                                   GLenum target,
                                                   egl::Image *image)
 {
@@ -3440,7 +3439,8 @@
             return false;
     }
 
-    if (!display->isValidImage(image))
+    ASSERT(context->getCurrentDisplay());
+    if (!context->getCurrentDisplay()->isValidImage(image))
     {
         context->handleError(InvalidValue() << "EGL image is not valid.");
         return false;