commit 68981eb56dd13dceb2ee7bd751e90ecc786621a5
author Olli Etuaho <oetuaho@nvidia.com> Tue Jan 23 17:46:12 2018 +0200
committer Commit Bot <commit-bot@chromium.org> Wed Jan 24 21:51:57 2018 +0000
tree 7ca4d7bd50d136a66340ec0af4c3db2dfe8d2ead
parent 12da5e7559adb117fb027f81babdbfa1d81c8922

Track parameter qualifiers of functions in call nodes

We now add a reference to TFunction to all TIntermAggregate nodes
where it is possible, including built-in ops. We also make sure
that internal TFunctions added in traversers have correct parameter
qualifiers.

This makes TLValueTrackingTraverser much simpler. Instead of storing
traversed functions or looking up builtin functions from the symbol
table, determining which function parameters are out parameters can
now be done simply by looking it up from the function symbol
associated with the aggregate node.

Symbol instances are no longer deleted when a symbol table level goes
out of scope, and TFunction destructor no longer clears the
parameters. They're all either statically allocated or pool allocated,
so this does not result in leaks.

TEST=angle_unittests
BUG=angleproject:2267

Change-Id: I57e5570da5b5a69a98a8778da3c2dc82b6284738
Reviewed-on: https://chromium-review.googlesource.com/881324
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

src/compiler/translator/Compiler.cpp

diff --git a/src/compiler/translator/Compiler.cpp b/src/compiler/translator/Compiler.cpp
index 669365b..030addf 100644
--- a/src/compiler/translator/Compiler.cpp
+++ b/src/compiler/translator/Compiler.cpp
@@ -402,7 +402,7 @@
     }
 
     if (shouldRunLoopAndIndexingValidation(compileOptions) &&
-        !ValidateLimitations(root, shaderType, &symbolTable, shaderVersion, &mDiagnostics))
+        !ValidateLimitations(root, shaderType, &symbolTable, &mDiagnostics))
     {
         return false;
     }
@@ -533,14 +533,14 @@
     SimplifyLoopConditions(root,
                            IntermNodePatternMatcher::kMultiDeclaration |
                                IntermNodePatternMatcher::kArrayLengthMethod | simplifyScalarized,
-                           &getSymbolTable(), getShaderVersion());
+                           &getSymbolTable());
 
     // Note that separate declarations need to be run before other AST transformations that
     // generate new statements from expressions.
     SeparateDeclarations(root);
 
     SplitSequenceOperator(root, IntermNodePatternMatcher::kArrayLengthMethod | simplifyScalarized,
-                          &getSymbolTable(), getShaderVersion());
+                          &getSymbolTable());
 
     RemoveArrayLengthMethod(root);
 
@@ -630,7 +630,7 @@
             SimplifyLoopConditions(root,
                                    IntermNodePatternMatcher::kArrayDeclaration |
                                        IntermNodePatternMatcher::kNamelessStructDeclaration,
-                                   &getSymbolTable(), getShaderVersion());
+                                   &getSymbolTable());
         }
 
         InitializeUninitializedLocals(root, getShaderVersion(), canUseLoopsToInitialize,