commit 6b19d7659f0906d46f82f92c31746ac7120f12d2
author Arun Patole <apatole@nvidia.com> Thu Feb 19 09:40:39 2015 +0530
committer Olli Etuaho <oetuaho@nvidia.com> Mon Feb 23 13:35:38 2015 +0000
tree df78c493157a54b5f9bd54ca5bf0753477e968be
parent 4ebb82e58c362138a7b19688dabecd8e6d0f5897

Implement missing variants of abs/sign

This change adds ANGLE support for abs/sign variants introduced
in ESSL3.

BUG=angle:923
TEST=Unit tests, dEQP tests

Unit Tests:
TypeTrackingTest.BuiltInAbsSignFunctionFloatResultTypeAndPrecision
TypeTrackingTest.BuiltInAbsSignFunctionIntResultTypeAndPrecision

dEQP tests passing 100% because of this change:
dEQP-GLES3.functional.shaders.builtin_functions.common.abs
dEQP-GLES3.functional.shaders.builtin_functions.common.sign

Change-Id: I2a3b028611f0eaaac3c031f8926d34a0e146663d
Reviewed-on: https://chromium-review.googlesource.com/251491
Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

src/compiler/translator/Initialize.cpp

diff --git a/src/compiler/translator/Initialize.cpp b/src/compiler/translator/Initialize.cpp
index 1fe2a89..d4f81c7 100644
--- a/src/compiler/translator/Initialize.cpp
+++ b/src/compiler/translator/Initialize.cpp
@@ -151,11 +151,21 @@
     symbolTable.insertBuiltIn(COMMON_BUILTINS, float3, "abs", float3);
     symbolTable.insertBuiltIn(COMMON_BUILTINS, float4, "abs", float4);
 
+    symbolTable.insertBuiltIn(ESSL3_BUILTINS, int1, "abs", int1);
+    symbolTable.insertBuiltIn(ESSL3_BUILTINS, int2, "abs", int2);
+    symbolTable.insertBuiltIn(ESSL3_BUILTINS, int3, "abs", int3);
+    symbolTable.insertBuiltIn(ESSL3_BUILTINS, int4, "abs", int4);
+
     symbolTable.insertBuiltIn(COMMON_BUILTINS, float1, "sign", float1);
     symbolTable.insertBuiltIn(COMMON_BUILTINS, float2, "sign", float2);
     symbolTable.insertBuiltIn(COMMON_BUILTINS, float3, "sign", float3);
     symbolTable.insertBuiltIn(COMMON_BUILTINS, float4, "sign", float4);
 
+    symbolTable.insertBuiltIn(ESSL3_BUILTINS, int1, "sign", int1);
+    symbolTable.insertBuiltIn(ESSL3_BUILTINS, int2, "sign", int2);
+    symbolTable.insertBuiltIn(ESSL3_BUILTINS, int3, "sign", int3);
+    symbolTable.insertBuiltIn(ESSL3_BUILTINS, int4, "sign", int4);
+
     symbolTable.insertBuiltIn(COMMON_BUILTINS, float1, "floor", float1);
     symbolTable.insertBuiltIn(COMMON_BUILTINS, float2, "floor", float2);
     symbolTable.insertBuiltIn(COMMON_BUILTINS, float3, "floor", float3);
@@ -907,6 +917,8 @@
     symbolTable.relateToOperator(COMMON_BUILTINS, "step",         EOpStep);
     symbolTable.relateToOperator(COMMON_BUILTINS, "smoothstep",   EOpSmoothStep);
 
+    symbolTable.relateToOperator(ESSL3_BUILTINS, "abs",           EOpAbs);
+    symbolTable.relateToOperator(ESSL3_BUILTINS, "sign",          EOpSign);
     symbolTable.relateToOperator(ESSL3_BUILTINS, "modf",          EOpModf);
     symbolTable.relateToOperator(ESSL3_BUILTINS, "min",           EOpMin);
     symbolTable.relateToOperator(ESSL3_BUILTINS, "max",           EOpMax);