commit 6be3d4cd9be84888b2767a07b65df3970a246125
author Geoff Lang <geofflang@chromium.org> Fri Jun 16 15:54:15 2017 -0400
committer Geoff Lang <geofflang@chromium.org> Wed Jun 21 14:39:37 2017 +0000
tree 28dcdf708fea22feb8e23372b76a250177100483
parent e7bd218c3efaf59367dbf8f71fbb68dc1de8d7bf

Fix incorrect format set being used for destination copy formats.

This validation matches Chrome's.

BUG=angleproject:1932

Change-Id: I2dc75c21924231ab75000dff92ef92cbc12adf55
Reviewed-on: https://chromium-review.googlesource.com/538956
Reviewed-by: Geoff Lang <geofflang@chromium.org>

src/libANGLE/validationES2.cpp

diff --git a/src/libANGLE/validationES2.cpp b/src/libANGLE/validationES2.cpp
index 6d7acae..228f4a7 100644
--- a/src/libANGLE/validationES2.cpp
+++ b/src/libANGLE/validationES2.cpp
@@ -232,11 +232,6 @@
     return IsValidCopyTextureSourceInternalFormatEnum(internalFormat);
 }
 
-bool IsValidCopySubTextureDestionationInternalFormat(GLenum internalFormat)
-{
-    return IsValidCopyTextureSourceInternalFormatEnum(internalFormat);
-}
-
 bool IsValidCopyTextureDestinationInternalFormatEnum(GLint internalFormat)
 {
     // Table 1.0 from the CHROMIUM_copy_texture spec
@@ -257,6 +252,7 @@
         case GL_SRGB8:
         case GL_RGB565:
         case GL_RGB8UI:
+        case GL_RGB10_A2:
         case GL_SRGB8_ALPHA8:
         case GL_RGB5_A1:
         case GL_RGBA4:
@@ -278,6 +274,11 @@
     }
 }
 
+bool IsValidCopySubTextureDestionationInternalFormat(GLenum internalFormat)
+{
+    return IsValidCopyTextureDestinationInternalFormatEnum(internalFormat);
+}
+
 bool IsValidCopyTextureDestinationFormatType(Context *context, GLint internalFormat, GLenum type)
 {
     if (!IsValidCopyTextureDestinationInternalFormatEnum(internalFormat))