commit 6f755b210f3515c44af8f0c963965ff7d4ce3213
author Jamie Madill <jmadill@chromium.org> Tue Oct 09 12:48:54 2018 -0400
committer Commit Bot <commit-bot@chromium.org> Tue Oct 09 20:27:56 2018 +0000
tree 686e0636d2ef251666d61c572efb39689a73ef52
parent abfbc0fe4e5a3e73a86d6b4f3299cde394cc42fb

Use angle::Result in front-end. (Part 1)

This covers most of the hot paths used in draw calls. Gives in the
order of a 5% reduction in draw call overhead.

Bug: angleproject:2491
Change-Id: I2d53afb1163eaceed61fb9cd9ce6c1267c85c0fa
Reviewed-on: https://chromium-review.googlesource.com/c/1258149
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

src/libANGLE/renderer/gl/FramebufferGL.cpp

diff --git a/src/libANGLE/renderer/gl/FramebufferGL.cpp b/src/libANGLE/renderer/gl/FramebufferGL.cpp
index c0ff1ea..c3b1913 100644
--- a/src/libANGLE/renderer/gl/FramebufferGL.cpp
+++ b/src/libANGLE/renderer/gl/FramebufferGL.cpp
@@ -619,13 +619,13 @@
     return (status == GL_FRAMEBUFFER_COMPLETE);
 }
 
-gl::Error FramebufferGL::syncState(const gl::Context *context,
-                                   const Framebuffer::DirtyBits &dirtyBits)
+angle::Result FramebufferGL::syncState(const gl::Context *context,
+                                       const gl::Framebuffer::DirtyBits &dirtyBits)
 {
     // Don't need to sync state for the default FBO.
     if (mIsDefault)
     {
-        return gl::NoError();
+        return angle::Result::Continue();
     }
 
     const FunctionsGL *functions = GetFunctionsGL(context);
@@ -720,7 +720,7 @@
                                                                getState());
     }
 
-    return gl::NoError();
+    return angle::Result::Continue();
 }
 
 GLuint FramebufferGL::getFramebufferID() const