commit 6f755b210f3515c44af8f0c963965ff7d4ce3213
author Jamie Madill <jmadill@chromium.org> Tue Oct 09 12:48:54 2018 -0400
committer Commit Bot <commit-bot@chromium.org> Tue Oct 09 20:27:56 2018 +0000
tree 686e0636d2ef251666d61c572efb39689a73ef52
parent abfbc0fe4e5a3e73a86d6b4f3299cde394cc42fb

Use angle::Result in front-end. (Part 1)

This covers most of the hot paths used in draw calls. Gives in the
order of a 5% reduction in draw call overhead.

Bug: angleproject:2491
Change-Id: I2d53afb1163eaceed61fb9cd9ce6c1267c85c0fa
Reviewed-on: https://chromium-review.googlesource.com/c/1258149
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

src/libANGLE/renderer/vulkan/VertexArrayVk.cpp

diff --git a/src/libANGLE/renderer/vulkan/VertexArrayVk.cpp b/src/libANGLE/renderer/vulkan/VertexArrayVk.cpp
index e673b95..9c3b75e 100644
--- a/src/libANGLE/renderer/vulkan/VertexArrayVk.cpp
+++ b/src/libANGLE/renderer/vulkan/VertexArrayVk.cpp
@@ -229,10 +229,10 @@
                                   bindings[attribs[INDEX].bindingIndex], INDEX)); \
         break;
 
-gl::Error VertexArrayVk::syncState(const gl::Context *context,
-                                   const gl::VertexArray::DirtyBits &dirtyBits,
-                                   const gl::VertexArray::DirtyAttribBitsArray &attribBits,
-                                   const gl::VertexArray::DirtyBindingBitsArray &bindingBits)
+angle::Result VertexArrayVk::syncState(const gl::Context *context,
+                                       const gl::VertexArray::DirtyBits &dirtyBits,
+                                       const gl::VertexArray::DirtyAttribBitsArray &attribBits,
+                                       const gl::VertexArray::DirtyBindingBitsArray &bindingBits)
 {
     ASSERT(dirtyBits.any());
 
@@ -294,7 +294,7 @@
         contextVk->invalidateCurrentPipeline();
     }
 
-    return gl::NoError();
+    return angle::Result::Continue();
 }
 
 angle::Result VertexArrayVk::syncDirtyAttrib(ContextVk *contextVk,