Suppress some failing end2end_tests on Intel.
BUG=589851
Change-Id: I91588014784a8a9b75389aeb596923458c30d80a
Reviewed-on: https://chromium-review.googlesource.com/329427
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
diff --git a/src/tests/test_utils/ANGLETest.cpp b/src/tests/test_utils/ANGLETest.cpp
index b1fb777..ee14e6c 100644
--- a/src/tests/test_utils/ANGLETest.cpp
+++ b/src/tests/test_utils/ANGLETest.cpp
@@ -433,58 +433,62 @@
mOSWindow->setVisible(isVisible);
}
-bool ANGLETest::isIntel() const
+bool IsIntel()
{
std::string rendererString(reinterpret_cast<const char *>(glGetString(GL_RENDERER)));
return (rendererString.find("Intel") != std::string::npos);
}
-bool ANGLETest::isAMD() const
+bool IsAMD()
{
std::string rendererString(reinterpret_cast<const char *>(glGetString(GL_RENDERER)));
return (rendererString.find("AMD") != std::string::npos) ||
(rendererString.find("ATI") != std::string::npos);
}
-bool ANGLETest::isNVidia() const
+bool IsNVIDIA()
{
std::string rendererString(reinterpret_cast<const char *>(glGetString(GL_RENDERER)));
return (rendererString.find("NVIDIA") != std::string::npos);
}
-bool ANGLETest::isD3D11() const
+bool IsD3D11()
{
std::string rendererString(reinterpret_cast<const char *>(glGetString(GL_RENDERER)));
return (rendererString.find("Direct3D11 vs_5_0") != std::string::npos);
}
-bool ANGLETest::isD3D11_FL93() const
+bool IsD3D11_FL93()
{
std::string rendererString(reinterpret_cast<const char *>(glGetString(GL_RENDERER)));
return (rendererString.find("Direct3D11 vs_4_0_") != std::string::npos);
}
-bool ANGLETest::isD3D9() const
+bool IsD3D9()
{
std::string rendererString(reinterpret_cast<const char *>(glGetString(GL_RENDERER)));
return (rendererString.find("Direct3D9") != std::string::npos);
}
-bool ANGLETest::isD3DSM3() const
+bool IsD3DSM3()
{
- std::string rendererString(reinterpret_cast<const char *>(glGetString(GL_RENDERER)));
- return isD3D9() || isD3D11_FL93();
+ return IsD3D9() || IsD3D11_FL93();
}
-bool ANGLETest::isOSX() const
+bool IsOSX()
{
-#ifdef __APPLE__
+#if defined(__APPLE__)
return true;
#else
return false;
#endif
}
+bool ANGLETest::isOpenGL() const
+{
+ return getPlatformRenderer() == EGL_PLATFORM_ANGLE_TYPE_OPENGL_ANGLE;
+}
+
EGLint ANGLETest::getPlatformRenderer() const
{
assert(mEGLWindow);
diff --git a/src/tests/test_utils/ANGLETest.h b/src/tests/test_utils/ANGLETest.h
index 106ac5f..3e73712 100644
--- a/src/tests/test_utils/ANGLETest.h
+++ b/src/tests/test_utils/ANGLETest.h
@@ -137,17 +137,7 @@
int getWindowHeight() const;
bool isMultisampleEnabled() const;
- bool isIntel() const;
- bool isAMD() const;
- bool isNVidia() const;
- // Note: FL9_3 is explicitly *not* considered D3D11.
- bool isD3D11() const;
- bool isD3D11_FL93() const;
- // Is a D3D9-class renderer.
- bool isD3D9() const;
- // Is D3D9 or SM9_3 renderer.
- bool isD3DSM3() const;
- bool isOSX() const;
+ bool isOpenGL() const;
EGLint getPlatformRenderer() const;
void ignoreD3D11SDKLayersWarnings();
@@ -174,4 +164,16 @@
virtual void TearDown();
};
+bool IsIntel();
+bool IsAMD();
+bool IsNVIDIA();
+// Note: FL9_3 is explicitly *not* considered D3D11.
+bool IsD3D11();
+bool IsD3D11_FL93();
+// Is a D3D9-class renderer.
+bool IsD3D9();
+// Is D3D9 or SM9_3 renderer.
+bool IsD3DSM3();
+bool IsOSX();
+
#endif // ANGLE_TESTS_ANGLE_TEST_H_