commit 72f58fa30559ff9f8444e1d6c3fd32e1112c6648
author Brandon Jones <brandon1.jones@intel.com> Tue Sep 19 10:47:41 2017 -0700
committer Commit Bot <commit-bot@chromium.org> Tue Sep 19 21:42:45 2017 +0000
tree 7dab815b7db77a111393d0b4a7a77504edf4d68a
parent 9abe07c652ed6e2a0f054a685a330226f4d58e51

Change Returned Error For Invalid Hint

When using FRAGMENT_SHADER_DERIVATIVE_HINT_OES as a hint with
OES_standard_derivatives disabled, we should return INVALID_ENUM, not
INVALID_OPERATION.

Bug: angleproject:2158

Change-Id: I5759f1e8bb19d2caed278506054aebc5d82d431c
Reviewed-on: https://chromium-review.googlesource.com/673374
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

src/libANGLE/validationES2.cpp

diff --git a/src/libANGLE/validationES2.cpp b/src/libANGLE/validationES2.cpp
index 1020933..7bf6506 100644
--- a/src/libANGLE/validationES2.cpp
+++ b/src/libANGLE/validationES2.cpp
@@ -5271,8 +5271,7 @@
             if (context->getClientVersion() < ES_3_0 &&
                 !context->getExtensions().standardDerivatives)
             {
-                context->handleError(InvalidOperation()
-                                     << "hint requires OES_standard_derivatives.");
+                context->handleError(InvalidEnum() << "hint requires OES_standard_derivatives.");
                 return false;
             }
             break;