commit 77abad8d9cbf4def5372e2461ed103a5dd1c3ab0
author Jamie Madill <jmadill@chromium.org> Thu Oct 25 17:03:48 2018 -0400
committer Commit Bot <commit-bot@chromium.org> Mon Oct 29 20:09:19 2018 +0000
tree 752814b8770521f7b34a0ee84ce59454b00c9c79
parent 1f056becd76b7733b78d65f5ca12b8c84f2e749d

Remove Context::gatherParams.

This won't be used in the future. It saves a few instructions on each
entry point.

Also refactors a bit of touched code. Also adds in a missed entry
point: "glTexStorage2DMultisampleANGLE".

Removes related code and moves remaining helper code in params.h into a
new file entry_point_utils.h.

In total this patch series reduces overhead by up to 5%.

Bug: angleproject:2933
Change-Id: Ifb49564597cde6ba82dfc3e185227619fdc62612
Reviewed-on: https://chromium-review.googlesource.com/c/1299478
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

src/libANGLE/renderer/vulkan/VertexArrayVk.cpp

diff --git a/src/libANGLE/renderer/vulkan/VertexArrayVk.cpp b/src/libANGLE/renderer/vulkan/VertexArrayVk.cpp
index 387f9d5..baae7ad 100644
--- a/src/libANGLE/renderer/vulkan/VertexArrayVk.cpp
+++ b/src/libANGLE/renderer/vulkan/VertexArrayVk.cpp
@@ -23,8 +23,8 @@
 {
 namespace
 {
-constexpr size_t kDynamicVertexDataSize = 1024 * 1024;
-constexpr size_t kDynamicIndexDataSize  = 1024 * 8;
+constexpr size_t kDynamicVertexDataSize    = 1024 * 1024;
+constexpr size_t kDynamicIndexDataSize     = 1024 * 8;
 constexpr size_t kMaxVertexFormatAlignment = 4;
 
 bool BindingIsAligned(const gl::VertexBinding &binding, unsigned componentSize)
@@ -182,7 +182,7 @@
     if (bytes > 0)
         numVertices += static_cast<size_t>(bytes) / binding.getStride();
 
-    void *src       = nullptr;
+    void *src = nullptr;
     ANGLE_TRY(srcBuffer->mapImpl(contextVk, &src));
     const uint8_t *srcBytes = reinterpret_cast<const uint8_t *>(src);
     srcBytes += binding.getOffset();
@@ -335,8 +335,8 @@
                 mCurrentArrayBufferResources[attribIndex] = &bufferVk->getBuffer();
                 mCurrentArrayBufferHandles[attribIndex] =
                     bufferVk->getBuffer().getBuffer().getHandle();
-                mCurrentArrayBufferOffsets[attribIndex]   = binding.getOffset();
-                mCurrentArrayBufferStrides[attribIndex]   = binding.getStride();
+                mCurrentArrayBufferOffsets[attribIndex] = binding.getOffset();
+                mCurrentArrayBufferStrides[attribIndex] = binding.getStride();
             }
         }
         else
@@ -436,7 +436,7 @@
                                                  GLenum indexTypeOrNone,
                                                  const void *indices)
 {
-    ContextVk *contextVk = vk::GetImpl(context);
+    ContextVk *contextVk                    = vk::GetImpl(context);
     const gl::AttributesMask &clientAttribs = context->getStateCache().getActiveClientAttribsMask();
 
     ASSERT(clientAttribs.any());