commit 794e0009ef747b49cd98d7d84434841a7ce5b222
author Minmin Gong <mgong@microsoft.com> Tue Apr 07 18:31:54 2015 -0700
committer Geoff Lang <geofflang@chromium.org> Thu Apr 09 20:13:48 2015 +0000
tree 9794196f609f464b7ae9f1a79e20d886c2355746
parent b3584fb4906588611a8e8fb59ffabdaa96e37006

Fix and enable warning C4244 (Conversion from 'type1' to 'type2', possible loss of data)

Change-Id: Id0e06d7d6600344d858f00dabc219d79289bbc82
Reviewed-on: https://chromium-review.googlesource.com/265020
Tested-by: Minmin Gong <mgong@microsoft.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

src/compiler/translator/SymbolTable.cpp

diff --git a/src/compiler/translator/SymbolTable.cpp b/src/compiler/translator/SymbolTable.cpp
index 0eb663f..9525040 100644
--- a/src/compiler/translator/SymbolTable.cpp
+++ b/src/compiler/translator/SymbolTable.cpp
@@ -152,10 +152,10 @@
 
     switch(type->getBasicType())
     {
-      case EbtGenType:  return new TType(EbtFloat, size);
-      case EbtGenIType: return new TType(EbtInt, size);
-      case EbtGenUType: return new TType(EbtUInt, size);
-      case EbtGenBType: return new TType(EbtBool, size);
+      case EbtGenType:  return new TType(EbtFloat, static_cast<unsigned char>(size));
+      case EbtGenIType: return new TType(EbtInt, static_cast<unsigned char>(size));
+      case EbtGenUType: return new TType(EbtUInt, static_cast<unsigned char>(size));
+      case EbtGenBType: return new TType(EbtBool, static_cast<unsigned char>(size));
       default: return type;
     }
 }
@@ -173,10 +173,10 @@
 
     switch(type->getBasicType())
     {
-      case EbtVec:  return new TType(EbtFloat, size);
-      case EbtIVec: return new TType(EbtInt, size);
-      case EbtUVec: return new TType(EbtUInt, size);
-      case EbtBVec: return new TType(EbtBool, size);
+      case EbtVec:  return new TType(EbtFloat, static_cast<unsigned char>(size));
+      case EbtIVec: return new TType(EbtInt, static_cast<unsigned char>(size));
+      case EbtUVec: return new TType(EbtUInt, static_cast<unsigned char>(size));
+      case EbtBVec: return new TType(EbtBool, static_cast<unsigned char>(size));
       default: return type;
     }
 }