commit 846fe05f9f4403a38bebbe0d135ca6da35dd3a8a
author Olli Etuaho <oetuaho@nvidia.com> Tue Jul 07 17:41:21 2015 +0300
committer Olli Etuaho <oetuaho@nvidia.com> Wed Jul 08 07:36:23 2015 +0000
tree c0208e61328760857a80bddd2b50fef756504bec
parent 6affeef6f1d4555655cefaf2438e887a22bf5a71

Disable using globals as l-values in global initializers

It should not be possible to use globals as l-values in global initializers.

This change was tested extensively with popular WebGL content, with no
regressions found.

TEST=angle_unittests
BUG=angleproject:988

Change-Id: I21ab731eb1d92aeae25795856ccae280792ad1f0
Reviewed-on: https://chromium-review.googlesource.com/283910
Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

src/compiler/translator/ValidateGlobalInitializer.cpp

diff --git a/src/compiler/translator/ValidateGlobalInitializer.cpp b/src/compiler/translator/ValidateGlobalInitializer.cpp
index 7b84b13..918cb85 100644
--- a/src/compiler/translator/ValidateGlobalInitializer.cpp
+++ b/src/compiler/translator/ValidateGlobalInitializer.cpp
@@ -18,6 +18,8 @@
 
     void visitSymbol(TIntermSymbol *node) override;
     bool visitAggregate(Visit visit, TIntermAggregate *node) override;
+    bool visitBinary(Visit visit, TIntermBinary *node) override;
+    bool visitUnary(Visit visit, TIntermUnary *node) override;
 
     bool isValid() const { return mIsValid; }
     bool issueWarning() const { return mIssueWarning; }
@@ -70,6 +72,24 @@
     return true;
 }
 
+bool ValidateGlobalInitializerTraverser::visitBinary(Visit visit, TIntermBinary *node)
+{
+    if (node->isAssignment())
+    {
+        mIsValid = false;
+    }
+    return true;
+}
+
+bool ValidateGlobalInitializerTraverser::visitUnary(Visit visit, TIntermUnary *node)
+{
+    if (node->isAssignment())
+    {
+        mIsValid = false;
+    }
+    return true;
+}
+
 ValidateGlobalInitializerTraverser::ValidateGlobalInitializerTraverser(const TParseContext *context)
     : TIntermTraverser(true, false, false),
       mContext(context),