commit 8b5e8fdb3c353d46c81243b31889856181ff66ae
author Olli Etuaho <oetuaho@nvidia.com> Fri Dec 15 14:59:15 2017 +0200
committer Commit Bot <commit-bot@chromium.org> Wed Jan 03 18:20:55 2018 +0000
tree 05ed91646e38bf161099dabee12a95e3dee1e65f
parent 93b059db4a5ab007e5239dff61eae3656e8da286

Replace remaining usage of TName with TSymbol

TName used to contain just a subset of the information stored in
TSymbol. It makes more sense to use TSymbol directly instead of
converting it to TName.

This also improves type safety a bit by making some functions only
take in TVariable or TFunction instead of the more generic TName.

BUG=angleproject:2267
TEST=angle_unittests

Change-Id: Icb46923c25d33ebbbbc06ddc487da25957dda771
Reviewed-on: https://chromium-review.googlesource.com/829143
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

src/compiler/translator/ValidateLimitations.cpp

diff --git a/src/compiler/translator/ValidateLimitations.cpp b/src/compiler/translator/ValidateLimitations.cpp
index e43ff37..23f9989 100644
--- a/src/compiler/translator/ValidateLimitations.cpp
+++ b/src/compiler/translator/ValidateLimitations.cpp
@@ -119,7 +119,7 @@
     {
         error(node->getLine(),
               "Loop index cannot be statically assigned to within the body of the loop",
-              node->getSymbol().c_str());
+              node->getName().c_str());
     }
 }
 
@@ -248,7 +248,7 @@
     if (!isConstExpr(declInit->getRight()))
     {
         error(declInit->getLine(), "Loop index cannot be initialized with non-constant expression",
-              symbol->getSymbol().c_str());
+              symbol->getName().c_str());
         return -1;
     }
 
@@ -282,7 +282,7 @@
     }
     if (symbol->uniqueId().get() != indexSymbolId)
     {
-        error(symbol->getLine(), "Expected loop index", symbol->getSymbol().c_str());
+        error(symbol->getLine(), "Expected loop index", symbol->getName().c_str());
         return false;
     }
     // Relational operator is one of: > >= < <= == or !=.
@@ -304,7 +304,7 @@
     if (!isConstExpr(binOp->getRight()))
     {
         error(binOp->getLine(), "Loop index cannot be compared with non-constant expression",
-              symbol->getSymbol().c_str());
+              symbol->getName().c_str());
         return false;
     }
 
@@ -353,7 +353,7 @@
     }
     if (symbol->uniqueId().get() != indexSymbolId)
     {
-        error(symbol->getLine(), "Expected loop index", symbol->getSymbol().c_str());
+        error(symbol->getLine(), "Expected loop index", symbol->getName().c_str());
         return false;
     }
 
@@ -381,7 +381,7 @@
         if (!isConstExpr(binOp->getRight()))
         {
             error(binOp->getLine(), "Loop index cannot be modified by non-constant expression",
-                  symbol->getSymbol().c_str());
+                  symbol->getName().c_str());
             return false;
         }
     }