Fix ImageIndexIterator termination.
There was an off-by-one error preventing proper iteration.
BUG=angleproject:1493
BUG=chromium:638323
Change-Id: I8a3907620a1503d16b039606a67fe3471f88e165
Reviewed-on: https://chromium-review.googlesource.com/380325
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
diff --git a/src/libANGLE/ImageIndexIterator_unittest.cpp b/src/libANGLE/ImageIndexIterator_unittest.cpp
index 2dc0b2a..2f97e8e 100644
--- a/src/libANGLE/ImageIndexIterator_unittest.cpp
+++ b/src/libANGLE/ImageIndexIterator_unittest.cpp
@@ -41,6 +41,8 @@
EXPECT_EQ(current.mipIndex, nextIndex.mipIndex);
EXPECT_EQ(current.layerIndex, nextIndex.layerIndex);
}
+
+ EXPECT_FALSE(iter.hasNext());
}
TEST(ImageIndexTest, IteratorCube)
@@ -64,6 +66,8 @@
EXPECT_TRUE(nextIndex.hasLayer());
}
}
+
+ EXPECT_FALSE(iter.hasNext());
}
TEST(ImageIndexTest, Iterator3D)
@@ -85,6 +89,8 @@
EXPECT_TRUE(nextIndex.hasLayer());
}
}
+
+ EXPECT_FALSE(iter.hasNext());
}
TEST(ImageIndexTest, Iterator2DArray)
@@ -109,6 +115,8 @@
EXPECT_TRUE(nextIndex.hasLayer());
}
}
+
+ EXPECT_FALSE(iter.hasNext());
}
} // namespace