commit 981afd7f49e237293dec5fa4253604bf3aa741b1
author Geoff Lang <geofflang@chromium.org> Wed Nov 05 16:30:36 2014 -0500
committer Geoff Lang <geofflang@chromium.org> Fri Nov 07 16:05:18 2014 +0000
tree 93148824183c3b98a82d56339820a8fc7d77254f
parent ad65a13cd1933086672b9644c23afb6d9d003c4c

Fix possible crash when the info log length is zero.

BUG=angle:822

Change-Id: I01cb590cc9c1ba05f4d63dd088eef7e176a09d2f
Reviewed-on: https://chromium-review.googlesource.com/227264
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

tests/angle_tests/ProgramBinaryTest.cpp

diff --git a/tests/angle_tests/ProgramBinaryTest.cpp b/tests/angle_tests/ProgramBinaryTest.cpp
index 6a48b35..eedf599 100644
--- a/tests/angle_tests/ProgramBinaryTest.cpp
+++ b/tests/angle_tests/ProgramBinaryTest.cpp
@@ -126,10 +126,16 @@
             GLint infoLogLength;
             glGetProgramiv(program2, GL_INFO_LOG_LENGTH, &infoLogLength);
 
-            std::vector<GLchar> infoLog(infoLogLength);
-            glGetProgramInfoLog(program2, infoLog.size(), NULL, &infoLog[0]);
-
-            FAIL() << "program link failed: " << &infoLog[0];
+            if (infoLogLength > 0)
+            {
+                std::vector<GLchar> infoLog(infoLogLength);
+                glGetProgramInfoLog(program2, infoLog.size(), NULL, &infoLog[0]);
+                FAIL() << "program link failed: " << &infoLog[0];
+            }
+            else
+            {
+                FAIL() << "program link failed.";
+            }
         }
         else
         {