commit a0a9e12ded57c70f28a3f467fafe100e32a684e5
author Jamie Madill <jmadill@chromium.org> Wed Sep 02 15:54:30 2015 -0400
committer Jamie Madill <jmadill@chromium.org> Wed Sep 02 21:04:35 2015 +0000
tree 54e292ebd303f0e566695dcaee4d2ccc93c73f93
parent beb81589d0961a085e576e2e182815bd71a68df9

translator: Add sh::OutputVariable type.

This replaces the dual-use of sh::Attribute, which can be a bit
confusing to people expecting a literal output variable.

Currently not used in Chromium, so should be safe to land.

BUG=angleproject:1146

Change-Id: I436f2bc9dc4ddc3709369cb2baa344c6b13a21a2
Reviewed-on: https://chromium-review.googlesource.com/296683
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

src/libANGLE/Program.cpp

diff --git a/src/libANGLE/Program.cpp b/src/libANGLE/Program.cpp
index 40ec835..30386f7 100644
--- a/src/libANGLE/Program.cpp
+++ b/src/libANGLE/Program.cpp
@@ -1701,14 +1701,14 @@
     if (fragmentShader->getShaderVersion() == 100)
         return;
 
-    const std::vector<sh::Attribute> &shaderOutputVars = fragmentShader->getActiveOutputVariables();
+    const auto &shaderOutputVars = fragmentShader->getActiveOutputVariables();
 
     // TODO(jmadill): any caps validation here?
 
     for (unsigned int outputVariableIndex = 0; outputVariableIndex < shaderOutputVars.size();
          outputVariableIndex++)
     {
-        const sh::Attribute &outputVariable = shaderOutputVars[outputVariableIndex];
+        const sh::OutputVariable &outputVariable = shaderOutputVars[outputVariableIndex];
 
         // Don't store outputs for gl_FragDepth, gl_FragColor, etc.
         if (outputVariable.isBuiltIn())