commit ab2bfa814ceefdcbe24483b3a12ba525345d486c
author Jamie Madill <jmadill@chromium.org> Tue Jan 15 19:06:47 2019 -0500
committer Commit Bot <commit-bot@chromium.org> Wed Jan 16 01:44:15 2019 +0000
tree 1ff0731e172d9cc4f468216501ef303914c95974
parent 3adcf1e4cb5ce3cc1cc8a3dfed4ec44dff45f5ae

Enable Chromium clang style plugin for libANGLE.

This fixes a few style warnings:

 * auto should not deduce to raw pointer type
 * inlined virtual methods are not allowed
 * non-trivial constructors and destructors should be explicit
 * inlined non-trivial constructors should not be in-class
 * missing override keywords

Bug: angleproject:3069
Change-Id: I3b3e55683691da3ebf6da06a5d3c729c71b6ee53
Reviewed-on: https://chromium-review.googlesource.com/c/1407640
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

src/libANGLE/Program.cpp

diff --git a/src/libANGLE/Program.cpp b/src/libANGLE/Program.cpp
index 7771425..3938ba6 100644
--- a/src/libANGLE/Program.cpp
+++ b/src/libANGLE/Program.cpp
@@ -1139,12 +1139,9 @@
     std::unique_ptr<ProgramLinkedResources> resources;
     if (mState.mAttachedShaders[ShaderType::Compute])
     {
-        resources.reset(
-            new ProgramLinkedResources{{0, PackMode::ANGLE_RELAXED},
-                                       {&mState.mUniformBlocks, &mState.mUniforms},
-                                       {&mState.mShaderStorageBlocks, &mState.mBufferVariables},
-                                       {&mState.mAtomicCounterBuffers},
-                                       {}});
+        resources.reset(new ProgramLinkedResources(
+            0, PackMode::ANGLE_RELAXED, &mState.mUniformBlocks, &mState.mUniforms,
+            &mState.mShaderStorageBlocks, &mState.mBufferVariables, &mState.mAtomicCounterBuffers));
 
         GLuint combinedImageUniforms = 0u;
         if (!linkUniforms(context->getCaps(), mInfoLog, mUniformLocationBindings,
@@ -1195,12 +1192,9 @@
             packMode = PackMode::WEBGL_STRICT;
         }
 
-        resources.reset(
-            new ProgramLinkedResources{{data.getCaps().maxVaryingVectors, packMode},
-                                       {&mState.mUniformBlocks, &mState.mUniforms},
-                                       {&mState.mShaderStorageBlocks, &mState.mBufferVariables},
-                                       {&mState.mAtomicCounterBuffers},
-                                       {}});
+        resources.reset(new ProgramLinkedResources(
+            data.getCaps().maxVaryingVectors, packMode, &mState.mUniformBlocks, &mState.mUniforms,
+            &mState.mShaderStorageBlocks, &mState.mBufferVariables, &mState.mAtomicCounterBuffers));
 
         if (!linkAttributes(context->getCaps(), mInfoLog))
         {