commit acf2f3adbac07ff91d280e9e2358d4bead0f0e67
author Jamie Madill <jmadill@chromium.org> Tue Nov 21 19:22:44 2017 -0500
committer Commit Bot <commit-bot@chromium.org> Wed Nov 22 06:34:40 2017 +0000
tree 79ecf2c0947fee768becc5f558589ff01a37e13b
parent f1b47e89631848b074ae0892126e0d675aaa26e4

Apply Chromium style fixes.

This addresses several minor code quality issues that are validated
in Chromium, but not yet applied to ANGLE:

* constructors and destructors must be defined out-of-line
* auto is not allowed for simple pointer types
* use override everywhere instead of virtual
* virtual functions must also be defined out-of-line

Slightly reduces binary size for me (~2k on Win, 150k on Linux).

Bug: angleproject:1569
Change-Id: I073ca3365188caf5f29fb28d9eb207903c1843e6
Reviewed-on: https://chromium-review.googlesource.com/779959
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

src/libANGLE/Image.cpp

diff --git a/src/libANGLE/Image.cpp b/src/libANGLE/Image.cpp
index 5612b9b..04c757c 100644
--- a/src/libANGLE/Image.cpp
+++ b/src/libANGLE/Image.cpp
@@ -78,7 +78,7 @@
     }
     else
     {
-        for (auto &sourceImage : mSourcesOf)
+        for (egl::Image *sourceImage : mSourcesOf)
         {
             ANGLE_TRY(sourceImage->orphanSibling(context, this));
         }
@@ -122,6 +122,10 @@
 {
 }
 
+ImageState::~ImageState()
+{
+}
+
 Image::Image(rx::EGLImplFactory *factory,
              EGLenum target,
              ImageSibling *buffer,