commit acf2f3adbac07ff91d280e9e2358d4bead0f0e67
author Jamie Madill <jmadill@chromium.org> Tue Nov 21 19:22:44 2017 -0500
committer Commit Bot <commit-bot@chromium.org> Wed Nov 22 06:34:40 2017 +0000
tree 79ecf2c0947fee768becc5f558589ff01a37e13b
parent f1b47e89631848b074ae0892126e0d675aaa26e4

Apply Chromium style fixes.

This addresses several minor code quality issues that are validated
in Chromium, but not yet applied to ANGLE:

* constructors and destructors must be defined out-of-line
* auto is not allowed for simple pointer types
* use override everywhere instead of virtual
* virtual functions must also be defined out-of-line

Slightly reduces binary size for me (~2k on Win, 150k on Linux).

Bug: angleproject:1569
Change-Id: I073ca3365188caf5f29fb28d9eb207903c1843e6
Reviewed-on: https://chromium-review.googlesource.com/779959
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

src/libANGLE/renderer/vulkan/ContextVk.cpp

diff --git a/src/libANGLE/renderer/vulkan/ContextVk.cpp b/src/libANGLE/renderer/vulkan/ContextVk.cpp
index 6972e6f..0ba2082 100644
--- a/src/libANGLE/renderer/vulkan/ContextVk.cpp
+++ b/src/libANGLE/renderer/vulkan/ContextVk.cpp
@@ -255,9 +255,9 @@
 
     VkDevice device       = mRenderer->getDevice();
     const auto &state     = mState.getState();
-    const auto &programGL = state.getProgram();
-    const auto &vao       = state.getVertexArray();
-    const auto *drawFBO   = state.getDrawFramebuffer();
+    const gl::Program *programGL   = state.getProgram();
+    const gl::VertexArray *vao     = state.getVertexArray();
+    const gl::Framebuffer *drawFBO = state.getDrawFramebuffer();
     ProgramVk *programVk  = vk::GetImpl(programGL);
     FramebufferVk *vkFBO  = vk::GetImpl(drawFBO);
     VertexArrayVk *vkVAO  = vk::GetImpl(vao);
@@ -308,9 +308,9 @@
     }
 
     const auto &state     = mState.getState();
-    const auto &programGL = state.getProgram();
+    const gl::Program *programGL = state.getProgram();
     ProgramVk *programVk  = vk::GetImpl(programGL);
-    const auto &vao       = state.getVertexArray();
+    const gl::VertexArray *vao   = state.getVertexArray();
     VertexArrayVk *vkVAO  = vk::GetImpl(vao);
     const auto *drawFBO   = state.getDrawFramebuffer();
     FramebufferVk *vkFBO  = vk::GetImpl(drawFBO);