commit ae4dbf32ba112c767d6e67d6e5734fc81d8c2d8c
author Olli Etuaho <oetuaho@nvidia.com> Fri Dec 08 20:49:00 2017 +0100
committer Commit Bot <commit-bot@chromium.org> Tue Dec 19 15:17:59 2017 +0000
tree ddcdc258ca58b847de1ca6d8e525e117760852ae
parent f2afccca7b27bf2a2415cbf066771295106500c5

Don't allocate name strings for empty symbols

This removes unnecessary memory allocations.

BUG=angleproject:2267
TEST=angle_unittests

Change-Id: Ide575ea19ab2f8e9fc93092490f1352efa6024a3
Reviewed-on: https://chromium-review.googlesource.com/817415
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

src/compiler/translator/RegenerateStructNames.cpp

diff --git a/src/compiler/translator/RegenerateStructNames.cpp b/src/compiler/translator/RegenerateStructNames.cpp
index a17e5d8..32940d8 100644
--- a/src/compiler/translator/RegenerateStructNames.cpp
+++ b/src/compiler/translator/RegenerateStructNames.cpp
@@ -19,12 +19,15 @@
     if (!userType)
         return;
 
-    if (userType->symbolType() == SymbolType::BuiltIn)
+    if (userType->symbolType() == SymbolType::BuiltIn ||
+        userType->symbolType() == SymbolType::Empty)
     {
-        // Built-in struct, do not touch it.
+        // Built-in struct or nameless struct, do not touch it.
         return;
     }
 
+    ASSERT(userType->name() != nullptr);
+
     int uniqueId = userType->uniqueId().get();
 
     ASSERT(mScopeDepth > 0);
@@ -50,14 +53,14 @@
         return;
     // Map {name} to _webgl_struct_{uniqueId}_{name}.
     const char kPrefix[] = "_webgl_struct_";
-    if (userType->name().find(kPrefix) == 0)
+    if (userType->name()->find(kPrefix) == 0)
     {
         // The name has already been regenerated.
         return;
     }
     std::string id = Str(uniqueId);
     TString tmp    = kPrefix + TString(id.c_str());
-    tmp += "_" + userType->name();
+    tmp += "_" + *userType->name();
     userType->setName(tmp);
 }