commit ae4dbf32ba112c767d6e67d6e5734fc81d8c2d8c
author Olli Etuaho <oetuaho@nvidia.com> Fri Dec 08 20:49:00 2017 +0100
committer Commit Bot <commit-bot@chromium.org> Tue Dec 19 15:17:59 2017 +0000
tree ddcdc258ca58b847de1ca6d8e525e117760852ae
parent f2afccca7b27bf2a2415cbf066771295106500c5

Don't allocate name strings for empty symbols

This removes unnecessary memory allocations.

BUG=angleproject:2267
TEST=angle_unittests

Change-Id: Ide575ea19ab2f8e9fc93092490f1352efa6024a3
Reviewed-on: https://chromium-review.googlesource.com/817415
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

src/compiler/translator/RemoveUnreferencedVariables.cpp

diff --git a/src/compiler/translator/RemoveUnreferencedVariables.cpp b/src/compiler/translator/RemoveUnreferencedVariables.cpp
index 36ed3f2..0f845cd 100644
--- a/src/compiler/translator/RemoveUnreferencedVariables.cpp
+++ b/src/compiler/translator/RemoveUnreferencedVariables.cpp
@@ -192,8 +192,8 @@
                 // Already an empty declaration - nothing to do.
                 return;
             }
-            TVariable *emptyVariable = new TVariable(mSymbolTable, NewPoolTString(""),
-                                                     declarator->getType(), SymbolType::Empty);
+            TVariable *emptyVariable =
+                new TVariable(mSymbolTable, nullptr, declarator->getType(), SymbolType::Empty);
             queueReplacementWithParent(node, declarator, new TIntermSymbol(emptyVariable),
                                        OriginalNode::IS_DROPPED);
             return;