commit ae6ba9f83dd0923e38d05768a1d3ff91a462cffa
author Jamie Madill <jmadill@chromium.org> Fri Dec 21 23:00:04 2018 -0500
committer Commit Bot <commit-bot@chromium.org> Sat Dec 22 05:14:33 2018 +0000
tree 682684b0ee6df68d9ff8c40a9e7944398d0eadee
parent 1e85326695b5150d20d404ed6596f49452bd01ff

Optimize check for active not paused XFB.

Local testing showed an improved score of about 2% in the most
sensitive CPU overhead benchmark. Likely because of improved
caching from fewer indirections.

Bug: angleproject:2966
Change-Id: I5d9a4b4bcf624ab0b430bb696c4227e589cdb7a6
Reviewed-on: https://chromium-review.googlesource.com/c/1359518
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

src/libANGLE/validationES.cpp

diff --git a/src/libANGLE/validationES.cpp b/src/libANGLE/validationES.cpp
index 9170c07..4046c97 100644
--- a/src/libANGLE/validationES.cpp
+++ b/src/libANGLE/validationES.cpp
@@ -2856,11 +2856,10 @@
         return false;
     }
 
-    const State &state                      = context->getGLState();
-    TransformFeedback *curTransformFeedback = state.getCurrentTransformFeedback();
-    if (curTransformFeedback && curTransformFeedback->isActive() &&
-        !curTransformFeedback->isPaused())
+    if (context->getStateCache().isTransformFeedbackActiveUnpaused())
     {
+        const State &state = context->getGLState();
+        TransformFeedback *curTransformFeedback = state.getCurrentTransformFeedback();
         if (!curTransformFeedback->checkBufferSpaceForDraw(count, primcount))
         {
             context->validationError(GL_INVALID_OPERATION, kTransformFeedbackBufferTooSmall);
@@ -2943,9 +2942,7 @@
 {
     const State &state = context->getGLState();
 
-    TransformFeedback *curTransformFeedback = state.getCurrentTransformFeedback();
-    if (curTransformFeedback && curTransformFeedback->isActive() &&
-        !curTransformFeedback->isPaused())
+    if (context->getStateCache().isTransformFeedbackActiveUnpaused())
     {
         // EXT_geometry_shader allows transform feedback to work with all draw commands.
         // [EXT_geometry_shader] Section 12.1, "Transform Feedback"