commit b27f79a7471e6dc8206e94df53f8c21bc096ad6e
author hendrikw <hendrikw@chromium.org> Wed Mar 04 11:26:46 2015 -0800
committer Geoff Lang <geofflang@chromium.org> Wed Mar 04 19:41:21 2015 +0000
tree ee21e2b172e401317059325baabe0a1885420dda
parent 72ba85bf7a8370152b377484e84cd9982cc29d18

Fix FloatCopySubImage tests for RGB

A test was checking that if we have less than 4 channels, and no
GL_EXT_texture_rg, we would expect an invalid operation.

Now that we don't expose GL_EXT_texture_rg on DX9, this is firing, and
I believe incorrectly.  I've changed the condition to test for less than
3 channals, since RGB -> RGB should work fine without texture_rg
support.

Change-Id: I9955b143c37df9762e0ef45c987581fab2bbcef0
Reviewed-on: https://chromium-review.googlesource.com/255933
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

tests/angle_tests/TextureTest.cpp

diff --git a/tests/angle_tests/TextureTest.cpp b/tests/angle_tests/TextureTest.cpp
index 147c1f7..34ebb79 100644
--- a/tests/angle_tests/TextureTest.cpp
+++ b/tests/angle_tests/TextureTest.cpp
@@ -165,7 +165,7 @@
         glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
         glTexSubImage2D(GL_TEXTURE_2D, 0, 0, 0, 2, 2, sourceUnsizedFormat, GL_FLOAT, imageData);
 
-        if (sourceImageChannels < 4 && !extensionEnabled("GL_EXT_texture_rg"))
+        if (sourceImageChannels < 3 && !extensionEnabled("GL_EXT_texture_rg"))
         {
             // This is not supported
             ASSERT_GL_ERROR(GL_INVALID_OPERATION);