commit bafefdf345a698679981eca1ed4f415f02374a17
author Geoff Lang <geofflang@chromium.org> Fri Oct 10 14:26:35 2014 -0400
committer Geoff Lang <geofflang@chromium.org> Fri Nov 07 19:29:16 2014 +0000
tree 7dd70a59d996210d0f17e9a8852971b62e6f2645
parent 468d7a1ed35defac29d55e463f59de6f80aedf3a

Add error handling to RenderTarget creation.

 * RenderTarget9/11 don't create any resources themselves anymore.
 * Pass the real internal format to RenderTarget creation so that it is
   not lost by converting to D3D formats and back.

BUG=angle:520

Change-Id: If420970d42f0bf6ce392d64f9cb7efa4df0b8f8e
Reviewed-on: https://chromium-review.googlesource.com/222838
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

src/libGLESv2/Renderbuffer.cpp

diff --git a/src/libGLESv2/Renderbuffer.cpp b/src/libGLESv2/Renderbuffer.cpp
index 30a7b86..90c758a 100644
--- a/src/libGLESv2/Renderbuffer.cpp
+++ b/src/libGLESv2/Renderbuffer.cpp
@@ -38,15 +38,21 @@
     SafeDelete(mRenderbuffer);
 }
 
-void Renderbuffer::setStorage(GLsizei width, GLsizei height, GLenum internalformat, GLsizei samples)
+Error Renderbuffer::setStorage(GLsizei width, GLsizei height, GLenum internalformat, GLsizei samples)
 {
+    Error error = mRenderbuffer->setStorage(width, height, internalformat, samples);
+    if (error.isError())
+    {
+        return error;
+    }
+
     mWidth = width;
     mHeight = height;
     mInternalFormat = internalformat;
     mSamples = samples;
-
-    mRenderbuffer->setStorage(width, height, internalformat, samples);
     mActualFormat = mRenderbuffer->getActualFormat();
+
+    return Error(GL_NO_ERROR);
 }
 
 rx::RenderbufferImpl *Renderbuffer::getImplementation()