commit bbe9fb5e956e875c7f6f916268002772d29f1fbb
author Olli Etuaho <oetuaho@nvidia.com> Thu Nov 03 17:16:05 2016 +0000
committer Commit Bot <commit-bot@chromium.org> Thu Nov 03 23:55:08 2016 +0000
tree 54ea03f3dbeaa44938e79c1334496095787d52c9
parent d9e837871dfa70006664579dfbeab6d8bcc822f5

Check that implicitly sized array constructors have arguments

Array size must be greater than zero according to the ESSL 3.00.6
spec.

BUG=angleproject:1602
TEST=angle_unittests

Change-Id: I1fa54b143bc821583822cbc5139464cdd058b6c1
Reviewed-on: https://chromium-review.googlesource.com/407257
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

src/compiler/translator/ParseContext.cpp

diff --git a/src/compiler/translator/ParseContext.cpp b/src/compiler/translator/ParseContext.cpp
index 45fe4a5..344c92f 100644
--- a/src/compiler/translator/ParseContext.cpp
+++ b/src/compiler/translator/ParseContext.cpp
@@ -2595,6 +2595,12 @@
     TType type = fnCall->getReturnType();
     if (type.isUnsizedArray())
     {
+        if (fnCall->getParamCount() == 0)
+        {
+            error(line, "implicitly sized array constructor must have at least one argument", "[]");
+            type.setArraySize(1u);
+            return TIntermTyped::CreateZero(type);
+        }
         type.setArraySize(static_cast<unsigned int>(fnCall->getParamCount()));
     }
     bool constType = true;