commit bf4e1b7312c0abade0914a635a4b97e5cf78e3f0
author Olli Etuaho <oetuaho@nvidia.com> Fri Dec 09 11:30:15 2016 +0000
committer Commit Bot <commit-bot@chromium.org> Tue Dec 13 18:44:53 2016 +0000
tree d9a3e2031bde5f166ca3e750515688291c5ac258
parent da9fb093e04c45dc4d0c41e682748e396d3710e7

Split TIntermInvariantDeclaration from TIntermAggregate

This change is pure refactoring and doesn't fix bugs related to
invariant declarations. Invariant declarations are supposed to accept
a list of identifiers, but this refactoring keeps the current behavior
of only accepting a single identifier in an invariant declaration.
When the bug will be fixed, the new TIntermInvariantDeclaration class
that now has only a single child node can be changed so that it may
have multiple children.

TIntermAggregate is still used for function calls, function
prototypes and function parameter lists.

BUG=angleproject:1490
TEST=angle_unittests

Change-Id: I3e22092c87e1c06445fd7e123d9922c2fcb59428
Reviewed-on: https://chromium-review.googlesource.com/419415
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

src/compiler/translator/VersionGLSL.cpp

diff --git a/src/compiler/translator/VersionGLSL.cpp b/src/compiler/translator/VersionGLSL.cpp
index 8dfd3cb..ad70479 100644
--- a/src/compiler/translator/VersionGLSL.cpp
+++ b/src/compiler/translator/VersionGLSL.cpp
@@ -92,15 +92,18 @@
     return true;
 }
 
+bool TVersionGLSL::visitInvariantDeclaration(Visit, TIntermInvariantDeclaration *node)
+{
+    ensureVersionIsAtLeast(GLSL_VERSION_120);
+    return true;
+}
+
 bool TVersionGLSL::visitAggregate(Visit, TIntermAggregate *node)
 {
     bool visitChildren = true;
 
     switch (node->getOp())
     {
-        case EOpInvariantDeclaration:
-            ensureVersionIsAtLeast(GLSL_VERSION_120);
-            break;
         case EOpParameters:
         {
             const TIntermSequence &params = *(node->getSequence());