commit bfe31c42e15e600d1cd873846459f40886ce59dc
author Jamie Madill <jmadill@chromium.org> Thu Oct 25 17:03:47 2018 -0400
committer Commit Bot <commit-bot@chromium.org> Sat Oct 27 14:50:07 2018 +0000
tree 6df87cd26f73f5ea480803514a424802ad36b42c
parent 8edb718892c86a2520ff8d0891fac72571793b23

Remove uses of DrawCallParams.

Packing and referencing this structure was causing unnecessary draw
call overhead. This improves performance on all the back-ends. Impacts
the GL back-end the most.

In total this patch series reduces overhead by up to 5%.

Bug: angleproject:2933
Change-Id: Ief416ab874e481baf960d02965978a311214a146
Reviewed-on: https://chromium-review.googlesource.com/c/1299477
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

src/libANGLE/renderer/vulkan/ProgramVk.h

diff --git a/src/libANGLE/renderer/vulkan/ProgramVk.h b/src/libANGLE/renderer/vulkan/ProgramVk.h
index 4822c19..64b538d 100644
--- a/src/libANGLE/renderer/vulkan/ProgramVk.h
+++ b/src/libANGLE/renderer/vulkan/ProgramVk.h
@@ -97,7 +97,7 @@
 
     // Also initializes the pipeline layout, descriptor set layouts, and used descriptor ranges.
     angle::Result initShaders(ContextVk *contextVk,
-                              const gl::DrawCallParams &drawCallParams,
+                              gl::PrimitiveMode mode,
                               const vk::ShaderAndSerial **vertexShaderAndSerialOut,
                               const vk::ShaderAndSerial **fragmentShaderAndSerialOut,
                               const vk::PipelineLayout **pipelineLayoutOut);
@@ -106,7 +106,6 @@
     angle::Result updateTexturesDescriptorSet(ContextVk *contextVk);
 
     angle::Result updateDescriptorSets(ContextVk *contextVk,
-                                       const gl::DrawCallParams &drawCallParams,
                                        vk::CommandBuffer *commandBuffer);
 
     // For testing only.