commit c1d770e88a9bf9f6159b8369f8f9772c98c49684
author Jamie Madill <jmadill@chromium.org> Thu Apr 13 17:31:24 2017 -0400
committer Commit Bot <commit-bot@chromium.org> Thu Apr 13 22:34:08 2017 +0000
tree dc3822c85a6438cae28cab05a894c8f5a36f1108
parent 3c68079cd326d1408441bb0f5ba7d0cf715ab4c6

Refactor remaining GLES 2.0 entry points.

This will pave the way for several features, like auto-generation.

BUG=angleproject:747

Change-Id: Ic390ac412f4e6b61346629093f185a4c07ea0284
Reviewed-on: https://chromium-review.googlesource.com/474118
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

src/libANGLE/Program.cpp

diff --git a/src/libANGLE/Program.cpp b/src/libANGLE/Program.cpp
index 037283b..2680741 100644
--- a/src/libANGLE/Program.cpp
+++ b/src/libANGLE/Program.cpp
@@ -490,39 +490,27 @@
     }
 }
 
-bool Program::detachShader(const Context *context, Shader *shader)
+void Program::detachShader(const Context *context, Shader *shader)
 {
     switch (shader->getType())
     {
         case GL_VERTEX_SHADER:
         {
-            if (mState.mAttachedVertexShader != shader)
-            {
-                return false;
-            }
-
+            ASSERT(mState.mAttachedVertexShader == shader);
             shader->release(context);
             mState.mAttachedVertexShader = nullptr;
             break;
         }
         case GL_FRAGMENT_SHADER:
         {
-            if (mState.mAttachedFragmentShader != shader)
-            {
-                return false;
-            }
-
+            ASSERT(mState.mAttachedFragmentShader == shader);
             shader->release(context);
             mState.mAttachedFragmentShader = nullptr;
             break;
         }
         case GL_COMPUTE_SHADER:
         {
-            if (mState.mAttachedComputeShader != shader)
-            {
-                return false;
-            }
-
+            ASSERT(mState.mAttachedComputeShader == shader);
             shader->release(context);
             mState.mAttachedComputeShader = nullptr;
             break;
@@ -530,8 +518,6 @@
         default:
             UNREACHABLE();
     }
-
-    return true;
 }
 
 int Program::getAttachedShadersCount() const