commit cc73f241145d24daea0c96460462f7aac5b83d8c
author Jamie Madill <jmadill@chromium.org> Wed Aug 01 11:34:48 2018 -0400
committer Commit Bot <commit-bot@chromium.org> Wed Aug 01 22:01:53 2018 +0000
tree 3be9f30bb5e4bc59f92497c2963cd8a744592363
parent 2da5356e574bca8489d9371c7d8e4cf4408211b2

Micro-optimize some validation checks.

Prepares for caching hasMappedBuffer. Also inclines several checks for
faster speed.

Bug: angleproject:2746
Change-Id: I74f9408d7b41e245c3f58d367dd2cc8fbace4a7a
Reviewed-on: https://chromium-review.googlesource.com/1150762
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Frank Henigman <fjhenigman@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

src/libANGLE/VertexArray.cpp

diff --git a/src/libANGLE/VertexArray.cpp b/src/libANGLE/VertexArray.cpp
index 8d933ac..040772a 100644
--- a/src/libANGLE/VertexArray.cpp
+++ b/src/libANGLE/VertexArray.cpp
@@ -486,4 +486,21 @@
     return false;
 }
 
+bool VertexArray::hasMappedEnabledArrayBuffer() const
+{
+    // TODO(jmadill): Cache this. http://anglebug.com/2746
+    for (size_t attribIndex : mState.mEnabledAttributesMask)
+    {
+        const VertexAttribute &vertexAttrib = mState.mVertexAttributes[attribIndex];
+        ASSERT(vertexAttrib.enabled);
+        const VertexBinding &vertexBinding = mState.mVertexBindings[vertexAttrib.bindingIndex];
+        gl::Buffer *boundBuffer            = vertexBinding.getBuffer().get();
+        if (boundBuffer && boundBuffer->isMapped())
+        {
+            return true;
+        }
+    }
+
+    return false;
+}
 }  // namespace gl