commit cd0a0a3c90d72f4a300346c92c9e957328d39d43
author Jamie Madill <jmadill@chromium.org> Thu Oct 18 18:41:57 2018 -0400
committer Jamie Madill <jmadill@chromium.org> Fri Oct 19 00:53:16 2018 +0000
tree e528565b0e49f60f5513933f17e0d4ab2472a58e
parent 472ddc8246724831c680d203a788b3b2de94d279

Introduce SubjectBindingPointer.

We can share the same pointer for the subject binding and the binding
pointer. This further allows us to optimize buffer re-binding. The
shared memory increases cache coherency and reduces the number of
instructions needed.

Bug: angleproject:2891
Change-Id: Id3162fa79de203f75989e7289ea02cb2ea1bec73
Reviewed-on: https://chromium-review.googlesource.com/c/1270217
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Frank Henigman <fjhenigman@chromium.org>

src/libANGLE/renderer/vulkan/VertexArrayVk.cpp

diff --git a/src/libANGLE/renderer/vulkan/VertexArrayVk.cpp b/src/libANGLE/renderer/vulkan/VertexArrayVk.cpp
index 9c3b75e..ffad3b1 100644
--- a/src/libANGLE/renderer/vulkan/VertexArrayVk.cpp
+++ b/src/libANGLE/renderer/vulkan/VertexArrayVk.cpp
@@ -123,7 +123,7 @@
                                              const void *sourcePointer,
                                              vk::DynamicBuffer *dynamicBuffer)
 {
-    ASSERT(!mState.getElementArrayBuffer().get() || indexType == GL_UNSIGNED_BYTE);
+    ASSERT(!mState.getElementArrayBuffer() || indexType == GL_UNSIGNED_BYTE);
 
     dynamicBuffer->releaseRetainedBuffers(contextVk->getRenderer());
 
@@ -251,7 +251,7 @@
         {
             case gl::VertexArray::DIRTY_BIT_ELEMENT_ARRAY_BUFFER:
             {
-                gl::Buffer *bufferGL = mState.getElementArrayBuffer().get();
+                gl::Buffer *bufferGL = mState.getElementArrayBuffer();
                 if (bufferGL)
                 {
                     BufferVk *bufferVk                 = vk::GetImpl(bufferGL);
@@ -485,7 +485,7 @@
         // Handle GL_LINE_LOOP drawElements.
         if (mDirtyLineLoopTranslation)
         {
-            gl::Buffer *elementArrayBuffer = mState.getElementArrayBuffer().get();
+            gl::Buffer *elementArrayBuffer = mState.getElementArrayBuffer();
 
             if (!elementArrayBuffer)
             {
@@ -540,7 +540,7 @@
     ASSERT(drawCallParams.isDrawElements());
     ASSERT(drawCallParams.mode() != gl::PrimitiveMode::LineLoop);
 
-    gl::Buffer *glBuffer = mState.getElementArrayBuffer().get();
+    gl::Buffer *glBuffer = mState.getElementArrayBuffer();
 
     if (!glBuffer)
     {