commit d4c09dd3286c5b4716ee5dd60837532d6b7ddc7f
author Jonah Ryan-Davis <jonahr@google.com> Tue Jan 29 11:22:54 2019 -0500
committer Commit Bot <commit-bot@chromium.org> Fri Feb 01 23:57:18 2019 +0000
tree e996feaac102a0ace6b2f0227d027fba14752f86
parent 65cd76a752aaa70017c6ac838a7fa2bb685fbdcc

Fix unnecessary copy of for loop variables in ANGLE

Bug: angleproject:3075
Change-Id: I34dd5d4ecded6def5a2b46369277312af0de7c8c
Reviewed-on: https://chromium-review.googlesource.com/c/1443572
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

src/compiler/translator/Compiler.cpp

diff --git a/src/compiler/translator/Compiler.cpp b/src/compiler/translator/Compiler.cpp
index afc8901..771d050 100644
--- a/src/compiler/translator/Compiler.cpp
+++ b/src/compiler/translator/Compiler.cpp
@@ -1095,9 +1095,9 @@
     for (size_t i = 0; i < mCallDag.size(); i++)
     {
         int depth    = 0;
-        auto &record = mCallDag.getRecordFromIndex(i);
+        const CallDAG::Record &record = mCallDag.getRecordFromIndex(i);
 
-        for (auto &calleeIndex : record.callees)
+        for (const int &calleeIndex : record.callees)
         {
             depth = std::max(depth, depths[calleeIndex] + 1);
         }
@@ -1122,7 +1122,7 @@
                     << mCallDag.getRecordFromIndex(currentFunction).node->getFunction()->name();
 
                 int nextFunction = -1;
-                for (auto &calleeIndex : mCallDag.getRecordFromIndex(currentFunction).callees)
+                for (const int &calleeIndex : mCallDag.getRecordFromIndex(currentFunction).callees)
                 {
                     if (depths[calleeIndex] == currentDepth - 1)
                     {
@@ -1273,7 +1273,7 @@
 {
     sh::InterfaceBlockList list;
 
-    for (auto block : mUniformBlocks)
+    for (const sh::InterfaceBlock &block : mUniformBlocks)
     {
         if (!block.staticUse &&
             (block.layout == sh::BLOCKLAYOUT_STD140 || block.layout == sh::BLOCKLAYOUT_SHARED))
@@ -1290,7 +1290,7 @@
     InitVariableList list;
     if (mShaderType == GL_VERTEX_SHADER || mShaderType == GL_GEOMETRY_SHADER_EXT)
     {
-        for (auto var : mOutputVaryings)
+        for (const sh::Varying &var : mOutputVaryings)
         {
             list.push_back(var);
             if (var.name == "gl_Position")
@@ -1303,7 +1303,7 @@
     else
     {
         ASSERT(mShaderType == GL_FRAGMENT_SHADER);
-        for (auto var : mOutputVariables)
+        for (const sh::OutputVariable &var : mOutputVariables)
         {
             list.push_back(var);
         }