Reland "Replace gl::trace logging with Chromium style logging"
Removing one usage of FormatString() and its static buffer.
And preparation for Platform logging.
Fix incorrect enabling of ERR() calls in UNIMPLEMENTED() and
UNREACHABLE(), resulting in increased code size and
<iostream> adding 5 static initializers to chrome because of
cerr referenced in statically linked translator.
BUG=angleproject:1660
Change-Id: I7caa18036118d532e0544f75278602559172ae04
Reviewed-on: https://chromium-review.googlesource.com/431457
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
diff --git a/src/libANGLE/validationES.cpp b/src/libANGLE/validationES.cpp
index e5ac455..3d9dba3 100644
--- a/src/libANGLE/validationES.cpp
+++ b/src/libANGLE/validationES.cpp
@@ -3219,8 +3219,8 @@
{
if (!context->getExtensions().webglCompatibility)
{
- ERR("This ANGLE implementation does not support separate front/back stencil "
- "writemasks, reference values, or stencil mask values.");
+ ERR() << "This ANGLE implementation does not support separate front/back stencil "
+ "writemasks, reference values, or stencil mask values.";
}
context->handleError(Error(GL_INVALID_OPERATION));
return false;
@@ -4697,7 +4697,7 @@
// We also output an error message to the debugger window if tracing is active, so that
// developers can see the error message.
- ERR("%s", errorMessage);
+ ERR() << errorMessage;
return false;
}