Disable broken tests on Fuchsia (reland)
This disables tests that do not work on Fuchsia. Most of them are related
to cube maps which currently crash inside the intel driver.
Reland disabling -Wextra-semi.
BUG=angleproject:2475, angleproject:3145, angleproject:3081
TEST=angle_end2end_tests on Fuchsia
Change-Id: I65ad84f43c88e8ee83c581cc2f41046d00bbae7f
Reviewed-on: https://chromium-review.googlesource.com/c/1467604
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
diff --git a/src/tests/gl_tests/ClearTest.cpp b/src/tests/gl_tests/ClearTest.cpp
index 9378eae..ea777e3 100644
--- a/src/tests/gl_tests/ClearTest.cpp
+++ b/src/tests/gl_tests/ClearTest.cpp
@@ -364,7 +364,7 @@
{
// Crashes on NVIDIA and Android in FramebufferVk::clearWithClearAttachments.
// http://anglebug.com/3081
- ANGLE_SKIP_TEST_IF(IsNVIDIA() || IsAndroid());
+ ANGLE_SKIP_TEST_IF(IsNVIDIA() || IsAndroid() || IsFuchsia());
GLRenderbuffer renderbuffer;
glBindRenderbuffer(GL_RENDERBUFFER, renderbuffer);
@@ -396,7 +396,7 @@
{
// Crashes on NVIDIA and Android in FramebufferVk::clearWithClearAttachments.
// http://anglebug.com/3081
- ANGLE_SKIP_TEST_IF(IsNVIDIA() || IsAndroid());
+ ANGLE_SKIP_TEST_IF(IsNVIDIA() || IsAndroid() || IsFuchsia());
GLRenderbuffer renderbuffer;
glBindRenderbuffer(GL_RENDERBUFFER, renderbuffer);
diff --git a/src/tests/gl_tests/CopyTextureTest.cpp b/src/tests/gl_tests/CopyTextureTest.cpp
index 529dad1..100c2da 100644
--- a/src/tests/gl_tests/CopyTextureTest.cpp
+++ b/src/tests/gl_tests/CopyTextureTest.cpp
@@ -2715,6 +2715,9 @@
// http://anglebug.com/1932
ANGLE_SKIP_TEST_IF(IsOSX() && IsIntel() && IsDesktopOpenGL());
+ // http://anglebug.com/3145
+ ANGLE_SKIP_TEST_IF(IsFuchsia() && IsIntel() && IsVulkan());
+
GLColor pixels[7] = {
GLColor(10u, 13u, 16u, 19u), GLColor(20u, 23u, 26u, 29u), GLColor(30u, 33u, 36u, 39u),
GLColor(40u, 43u, 46u, 49u), GLColor(50u, 53u, 56u, 59u), GLColor(60u, 63u, 66u, 69u),
@@ -2776,6 +2779,9 @@
return;
}
+ // http://anglebug.com/3145
+ ANGLE_SKIP_TEST_IF(IsFuchsia() && IsIntel() && IsVulkan());
+
GLColor pixels[7] = {
GLColor(10u, 13u, 16u, 19u), GLColor(20u, 23u, 26u, 29u), GLColor(30u, 33u, 36u, 39u),
GLColor(40u, 43u, 46u, 49u), GLColor(50u, 53u, 56u, 59u), GLColor(60u, 63u, 66u, 69u),
@@ -2837,6 +2843,9 @@
// http://anglebug.com/1932
ANGLE_SKIP_TEST_IF(IsOSX() && IsIntel() && IsDesktopOpenGL());
+ // http://anglebug.com/3145
+ ANGLE_SKIP_TEST_IF(IsFuchsia() && IsIntel() && IsVulkan());
+
constexpr uint8_t pixels[16 * 7] = {
0u, 3u, 6u, 10u, 13u, 16u, 0, 0, 20u, 23u, 26u, 30u, 33u, 36u, 0, 0, // 2x2
40u, 43u, 46u, 50u, 53u, 56u, 0, 0, 60u, 63u, 66u, 70u, 73u, 76u, 0, 0, // 2x2
diff --git a/src/tests/gl_tests/CubeMapTextureTest.cpp b/src/tests/gl_tests/CubeMapTextureTest.cpp
index 4522797..fac12a4 100644
--- a/src/tests/gl_tests/CubeMapTextureTest.cpp
+++ b/src/tests/gl_tests/CubeMapTextureTest.cpp
@@ -63,6 +63,9 @@
// TODO: Diagnose and fix. http://anglebug.com/2954
ANGLE_SKIP_TEST_IF(IsVulkan() && IsIntel() && IsWindows());
+ // http://anglebug.com/3145
+ ANGLE_SKIP_TEST_IF(IsVulkan() && IsIntel() && IsFuchsia());
+
const GLfloat faceColors[] = {
1.0f, 0.0f, 0.0f, 1.0f, 0.0f, 1.0f, 0.0f, 1.0f, 0.0f, 0.0f, 1.0f, 1.0f,
1.0f, 1.0f, 0.0f, 1.0f, 1.0f, 0.0f, 1.0f, 1.0f, 0.0f, 1.0f, 1.0f, 1.0f,
diff --git a/src/tests/gl_tests/FramebufferTest.cpp b/src/tests/gl_tests/FramebufferTest.cpp
index 5100fe5..60ad770 100644
--- a/src/tests/gl_tests/FramebufferTest.cpp
+++ b/src/tests/gl_tests/FramebufferTest.cpp
@@ -272,6 +272,9 @@
// Test that binding an incomplete cube map is rejected by ANGLE.
TEST_P(FramebufferFormatsTest, IncompleteCubeMap)
{
+ // http://anglebug.com/3145
+ ANGLE_SKIP_TEST_IF(IsFuchsia() && IsIntel() && IsVulkan());
+
// First make a complete CubeMap.
glGenTextures(1, &mTexture);
glBindTexture(GL_TEXTURE_CUBE_MAP, mTexture);
diff --git a/src/tests/gl_tests/MipmapTest.cpp b/src/tests/gl_tests/MipmapTest.cpp
index 9290f87..c6a9df6 100644
--- a/src/tests/gl_tests/MipmapTest.cpp
+++ b/src/tests/gl_tests/MipmapTest.cpp
@@ -781,6 +781,9 @@
// TODO(jmadill): Diagnose and fix. http://anglebug.com/2817
ANGLE_SKIP_TEST_IF(IsVulkan() && IsAndroid());
+ // http://anglebug.com/3145
+ ANGLE_SKIP_TEST_IF(IsFuchsia() && IsIntel() && IsVulkan());
+
glBindTexture(GL_TEXTURE_CUBE_MAP, mTextureCube);
// Draw. Since the negative-Y face's is blue, this should be blue.
@@ -820,6 +823,9 @@
// This test ensures that rendering to level-zero of a TextureCube works as expected.
TEST_P(MipmapTest, TextureCubeRenderToLevelZero)
{
+ // http://anglebug.com/3145
+ ANGLE_SKIP_TEST_IF(IsFuchsia() && IsIntel() && IsVulkan());
+
glBindTexture(GL_TEXTURE_CUBE_MAP, mTextureCube);
// Draw. Since the negative-Y face's is blue, this should be blue.
diff --git a/src/tests/gl_tests/TextureTest.cpp b/src/tests/gl_tests/TextureTest.cpp
index dc65d7e..85485a5 100644
--- a/src/tests/gl_tests/TextureTest.cpp
+++ b/src/tests/gl_tests/TextureTest.cpp
@@ -1349,6 +1349,9 @@
// https://code.google.com/p/angleproject/issues/detail?id=849
TEST_P(TextureCubeTest, CubeMapFBO)
{
+ // http://anglebug.com/3145
+ ANGLE_SKIP_TEST_IF(IsFuchsia() && IsIntel() && IsVulkan());
+
GLFramebuffer fbo;
glBindFramebuffer(GL_FRAMEBUFFER, fbo);
@@ -1391,6 +1394,9 @@
// TODO(jie.a.chen): Diagnose and fix. http://anglebug.com/2822
ANGLE_SKIP_TEST_IF(IsVulkan() && IsIntel() && IsWindows());
+ // http://anglebug.com/3145
+ ANGLE_SKIP_TEST_IF(IsFuchsia() && IsIntel() && IsVulkan());
+
constexpr size_t kSize = 16;
GLFramebuffer fbo;